Enable creating a static resource from a URL #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maudetes
approved these changes
Sep 4, 2025
| ) | ||
| with self._client.session.stream("GET", file_to_upload) as streamed: | ||
| streamed.raise_for_status() | ||
| streamed.read() |
There was a problem hiding this comment.
It is apparently the syntax for httpx
| raise ValueError( | ||
| "When uploading from a URL, file_name and mime arguments are required." | ||
| ) | ||
| with self._client.session.stream("GET", file_to_upload) as streamed: |
There was a problem hiding this comment.
Could we open/close the session stream without a with context in order to mutualise the POST logic with just a different files dict?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could also retrieve/build
file_nameandmimefrom the URL's headers, but it sounds safer to ask the user to fill them in, idk 🤔