fix(test): resolve search test flakiness with enhanced SearchRequestHandler cache key #15299
+77
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product
datahub-cyborg
bot
added
the
needs-review
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
deepgarg760
reviewed
Nov 17, 2025
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return entitySpecs.hashCode(); |
Collaborator
There was a problem hiding this comment.
implementation of hashcode and equals is out of sync. It can reimplemented
datahub-cyborg
bot
added
pending-submitter-response
deepgarg760
reviewed
Nov 17, 2025
| "urn:li:dataset:(urn:li:dataPlatform:bigquery,bigquery-public-data.covid19_geotab_mobility_impact.ca_border_wait_times,PROD)"); | ||
| assertTrue(explainResponse.isExists()); | ||
| assertEquals(explainResponse.getExplanation().getValue(), 18.0f); | ||
| assertEquals(explainResponse.getExplanation().getValue(), 1.25f); |
Collaborator
There was a problem hiding this comment.
why this has changed ? Seems to be unrelated with the fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced entitySpecs-based cache key with comprehensive SearchHandlerKey that includes all configuration components. This prevents test instability where different search configurations with identical entitySpecs would incorrectly share already cached handler instances.