Skip to content

Conversation

@ChengJiale150
Copy link
Contributor

@ChengJiale150 ChengJiale150 commented Oct 17, 2025

see in #127

What's Changed

list_files

🚀 New Features

  • Pagination Support: Added start_index and limit parameters for controling max Token return by Tool
  • Pattern Filtering: Added pattern parameter supporting glob for filtering file paths
  • Improved Depth Control: Changed default max_depth from 3 to 1 to prevent excessive recursion

🔧 Technical Improvements

  • Code Refactoring: Moved recursive file listing logic from utils.py to list_files_tool.py for better organization
  • Enhanced Error Handling: Better error handling for inaccessible directories and wrong parameter input.
  • Better Description: Add use cases and range validation for the tool in the description

📝 Parameter Changes

  • max_depth: Maximum depth to recurse into subdirectories (default: 1, range: 0-3)
  • start_index: Starting index for pagination (default: 0, minimum: 0)
  • limit: Maximum number of items to return (default: 25, 0 means no limit)
  • pattern: Glob pattern to filter file paths (optional)

📋 Usage Examples

# List root directory with default settings (max_depth=1, limit=25)
list_files()

# List with custom depth and pagination
list_files(path="notebooks", max_depth=2, start_index=0, limit=50)

# Filter for Python files only
list_files(pattern="*.py")

# Deep search with no pagination limits
list_files(max_depth=3, limit=0)

@ChengJiale150
Copy link
Contributor Author

assign_kernel_to_notebook

🗑️ Removed assign_kernel_to_notebook Tool:

  • Completely removed the assign_kernel_to_notebook tool functionality
  • Deleted assign_kernel_to_notebook_tool.py file
  • Removed tool registration from tools/__init__.py
  • Updated server integration in server.py
  • Cleaned up related tests and documentation

Impact:

  • Reduced total tool count from 16 to 15 tools
  • Simplified the codebase by removing redundant kernel assignment functionality

@ChengJiale150
Copy link
Contributor Author

Still in Progress, don't change docs.

@ChengJiale150 ChengJiale150 marked this pull request as ready for review October 17, 2025 14:23
@ChengJiale150
Copy link
Contributor Author

ChengJiale150 commented Oct 17, 2025

This is just one of small step in #127 and I prefer to update docs and version in final PR.

@ChengJiale150 ChengJiale150 marked this pull request as draft October 17, 2025 15:00
@ChengJiale150 ChengJiale150 marked this pull request as ready for review October 17, 2025 15:29
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thx @ChengJiale150

@echarles echarles merged commit 398616e into datalayer:main Oct 17, 2025
15 of 16 checks passed
@ChengJiale150 ChengJiale150 deleted the feat/jupyter-manager-tools-enhance branch October 22, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants