Fix duplicate kernel creation bug in use_notebook tool #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug where kernel_id variable was not being updated after creating a new kernel in JUPYTER_SERVER mode. This caused create_session() to receive None as kernel_id, which resulted in creating a second kernel while the first kernel remained unused. The fix ensures that when a new kernel is created via _start_kernel_local(), the kernel_id variable is properly assigned from the returned kernel dictionary. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where kernel_id variable was not being updated after creating a new kernel in JUPYTER_SERVER mode. This caused create_session() to receive None as kernel_id, which resulted in creating a second kernel while the first kernel remained unused.
The fix ensures that when a new kernel is created via _start_kernel_local(), the kernel_id variable is properly assigned from the returned kernel dictionary.