Pydantic fix for appending insert_execute_code_cell to the end of notebook #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update `extract_output` in `utils.py` to detect and serialize Plotly data structures into formatted JSON strings. - Filter out non-standard `transient` fields from execution outputs to improve `nbformat` schema compliance. - Change health check route from `/api/healthz` to `/api/health` in `server.py`. - Add debug logging for output data keys to assist with visualization detection.
Updated cell_index parameter to allow -1 as a valid index.
Added test for appending code cell to notebook.
Member
|
change to health seem to impact the tests (not sure though... mcp server seem to not start or not being ack via health) |
Contributor
Author
|
It looks like there are some other areas using the healthz endpoint, should have checked, my fault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue with the validation in jupyter_mcp_server/server.py
@mcp.tool()
async def insert_execute_code_cell(
cell_index: Annotated[int, Field(description="Index of the cell to insert and execute (0-based)", ge=0)]
This prevents the index from being set to -1 , which appends the cell to the bottom of the notebook.
-Changed ge=0 to ge=-1.
-Added unit test for appending code cell in test_tools .py
-Mispelling of health api endpoint (was healthz)
-Added handling of Plotly json data output if the cell is executing plotly code.