Skip to content

Conversation

@goanpeca
Copy link
Collaborator

@goanpeca goanpeca commented Nov 14, 2025

Fixes #65

Requires datalayer/jupyter-ui#426

drag

Copilot AI review requested due to automatic review settings November 14, 2025 02:45
@goanpeca goanpeca self-assigned this Nov 14, 2025
@netlify
Copy link

netlify bot commented Nov 14, 2025

Deploy Preview for vscode-datalayer failed. Why did it fail? →

Name Link
🔨 Latest commit b86c8d7
🔍 Latest deploy log https://app.netlify.com/projects/vscode-datalayer/deploys/69169ca3ff7aae00089e4a81

Copilot finished reviewing on behalf of goanpeca November 14, 2025 02:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes styling issues with draggable lexical nodes by adding VS Code theme integration and scroll compensation fixes to the draggable block plugin.

Key Changes:

  • Added theme class configuration for draggable block menu and target line
  • Implemented CSS styling using VS Code theme variables
  • Fixed scroll position calculations in the draggable block plugin

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
webview/lexical/LexicalEditor.tsx Adds theme class configuration for draggableBlockMenu and draggableBlockTargetLine
webview/lexical/LexicalEditor.css Implements VS Code themed hover and focus styles for draggable elements
patches/@datalayer+jupyter-react+1.1.8.patch Updates notebook adapter with enhanced undo/redo functionality and exports
patches/@datalayer+jupyter-lexical+1.0.6.patch Fixes scroll compensation bugs in draggable block positioning with extensive debug logging

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

📦 Extension Build Ready!

Download the extension (works on all platforms):

📥 Download build artifact

The artifact contains the .vsix extension package.


📖 Installation Instructions

Method 1: VS Code UI

  1. Download the .vsix file above
  2. Open VS Code
  3. Go to Extensions (Ctrl+Shift+X / Cmd+Shift+X)
  4. Click ... menu → "Install from VSIX..."
  5. Select the downloaded file

Method 2: Command Line

code --install-extension datalayer-jupyter-vscode.vsix

Method 3: Drag & Drop

  1. Download the .vsix file
  2. Drag it into the VS Code Extensions sidebar

Note: The .vsix artifact works on Windows, macOS, and Linux.

Built from commit b86c8d7 • Version 0.0.6View workflow run

@goanpeca goanpeca force-pushed the fix/draggable-nodes branch from 2cc476e to e7330fd Compare November 14, 2025 02:55
@goanpeca goanpeca requested a review from echarles November 14, 2025 02:57
@goanpeca goanpeca force-pushed the fix/draggable-nodes branch from e7330fd to b86c8d7 Compare November 14, 2025 03:06
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT Thx @goanpeca

@echarles echarles merged commit ba52ff6 into main Nov 14, 2025
11 of 15 checks passed
@goanpeca goanpeca deleted the fix/draggable-nodes branch November 14, 2025 13:10
@goanpeca goanpeca restored the fix/draggable-nodes branch November 14, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable dragging nodes when scrolling

3 participants