-
-
Notifications
You must be signed in to change notification settings - Fork 0
Fix styling for usage with draggable lexical nodes #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Deploy Preview for vscode-datalayer failed. Why did it fail? →
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes styling issues with draggable lexical nodes by adding VS Code theme integration and scroll compensation fixes to the draggable block plugin.
Key Changes:
- Added theme class configuration for draggable block menu and target line
- Implemented CSS styling using VS Code theme variables
- Fixed scroll position calculations in the draggable block plugin
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| webview/lexical/LexicalEditor.tsx | Adds theme class configuration for draggableBlockMenu and draggableBlockTargetLine |
| webview/lexical/LexicalEditor.css | Implements VS Code themed hover and focus styles for draggable elements |
| patches/@datalayer+jupyter-react+1.1.8.patch | Updates notebook adapter with enhanced undo/redo functionality and exports |
| patches/@datalayer+jupyter-lexical+1.0.6.patch | Fixes scroll compensation bugs in draggable block positioning with extensive debug logging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📦 Extension Build Ready!Download the extension (works on all platforms): The artifact contains the 📖 Installation InstructionsMethod 1: VS Code UI
Method 2: Command Linecode --install-extension datalayer-jupyter-vscode.vsixMethod 3: Drag & Drop
|
2cc476e to
e7330fd
Compare
e7330fd to
b86c8d7
Compare
echarles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT Thx @goanpeca
Fixes #65
Requires datalayer/jupyter-ui#426