Skip to content

Bug fixes for HADR checks #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Bug fixes for HADR checks #1037

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5ea03f
Bugfix for finding $Replicas
michele-tahay-kohera Aug 28, 2025
604f972
$return object should not get nullified
michele-tahay-kohera Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/checks/HADR.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function Get-ClusterObject {
$PreviousClusterNode = $AGResource.OwnerNode.Name
# We get cluster node owner first ...
# We need then for each owner to find out the corresponding replicas => SQL Instance Name + Port
$Replicas = Find-DbaInstance -ComputerName $AGResource.OwnerNode.Name
$Replicas = Find-DbaInstance -ComputerName $AGResource.OwnerNode.Name | Where-Object {$_.Services.ServiceName -ne $null }
}

# Finally for each replica detected (SQL Server + Port)
Expand All @@ -53,7 +53,7 @@ function Get-ClusterObject {
}
}
catch {
$return = $null
$return.AvailabilityGroups[$AGResource.Name] = 'FailedToConnect'
}
}

Expand Down