Issue/443 improve allow list bundle execution performance#444
Open
Issue/443 improve allow list bundle execution performance#444
Conversation
* SQL logging delegates are now only created if logging is enabled * Disabled SQL logging for dao and integration tests, can be enabled with constants in dev.dsf.bpe.dao.AbstractDbTest and dev.dsf.fhir.dao.AbstractDbTest * Added missing SQL logging delegate config for Operaton data source * Some code cleanup
- New "not found" cache for metadata resources by Url and by Url and Version queries. - Added "current" column to resource tables with default value "true", after insert trigger sets current to false for old versions. New after insert triggers for resource tables that are not part of read_accesss mechanism: Questionnaire, StructureDefinition (snapshot) and Task. Update queries run on db schema migration to set current to false for existing older resource versions. Updated current... and dependent views. - Added a few new db indexes: ...id_current_index to speedup finding the current resource via the current... views, ...full_id and ...ref indexes to speedup queries with OrganizationAffiliation to Organization and Endpoint relations. - Refactored SQL queries using concat(...) to || (concat operator) to enable index usage. - A few other refactored queries to make better use of new current indexes.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code and DB schema improvements to speedup allow-list bundle executions.
Peak at execution 79 develop branch may be related to autovacuum execution.
closes #443