Skip to content

Conversation

@bereng
Copy link
Collaborator

@bereng bereng commented Feb 12, 2025

What is the issue

The customer requested an upgrade for some libraries (CVEs)

What does this PR fix and why was it fixed

This PR upgrades to latest stable versions

@github-actions
Copy link

github-actions bot commented Feb 12, 2025

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

@bereng bereng changed the title Upgrade of the jackson library to 2.18.0 Upgrade of several libraries Feb 13, 2025
@bereng bereng changed the title Upgrade of several libraries HCD-62 Upgrade of several libraries Feb 13, 2025
@bereng
Copy link
Collaborator Author

bereng commented Feb 17, 2025

The only CI failure seems to be https://datastax.jira.com/browse/CNDB-4763

Perf reports look good or even a bit better (ran against Szymon's run from a few days ago to save $):

@bereng
Copy link
Collaborator Author

bereng commented Feb 18, 2025

Note to self: The commit message will have to be amended before merge to reflect Guava stays at v29

@bereng
Copy link
Collaborator Author

bereng commented Feb 20, 2025

CI LGTM. Perf tests LGTM even with slightly better numbers:

@JeremiahDJordan
Copy link
Member

Please update the commit messages and pr description to list all the CVEs being fixed here.

@bereng bereng force-pushed the HCD-62-HCD-1.1 branch 2 times, most recently from f56bcca to 229cab9 Compare March 10, 2025 12:20
@szymon-miezal
Copy link

@bereng could you rebase the PR to trigger the CI on the updated branch?

Copy link

@szymon-miezal szymon-miezal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me, I have left a few questions/comments.

This commit contains the following upgrades
* snappy to 1.1.10.7 fixing CVE-2023-43642
* guava to 33.4.0-jre fixing CVE-2023-2976 and CVE-2020-8908
* jackson to 2.18.0 fixing CWE-400
* snakeyaml to 2.4 fixing CVE-2022-1471
@sonarqubecloud
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1563 rejected by Butler


1 new test failure(s) in 10 builds
See build details here


Found 1 new test failures

Test Explanation Branch history Upstream history
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS... regression 🔴🔴🔵🔴🔴🔵🔴 🔵🔵🔵🔵🔵🔵🔵

Found 18 known test failures

@bereng bereng merged commit f38360e into main Mar 25, 2025
474 of 479 checks passed
@bereng bereng deleted the HCD-62-HCD-1.1 branch March 25, 2025 06:36
jkni added a commit that referenced this pull request Apr 8, 2025
…ate cdc_enabled key in base yaml (#1680)

### What is the issue
#1563 upgraded our version of snakeyaml. This new version logs when
duplicate keys are found. The test-cdc target concatenates a
CDC-specific yaml to the base yaml. Both contain entries for the
cdc_enabled key, causing tests that load this yaml to log the warning.
This causes CDC CI failures.

### What does this PR fix and why was it fixed
This PR removes the cdc_enabled entry in the base yaml, as it's the same
as the default. This is consistent with how we handle other default keys
that might be duplicated across multiple yaml fragments in the test
commands.
djatnieks pushed a commit that referenced this pull request Apr 14, 2025
The customer requested an upgrade for some libraries (CVEs)

This PR upgrades to latest stable versions

- snappy to 1.1.10.7 fixing CVE-2023-43642
- guava to 33.4.0-jre fixing CVE-2023-2976 and CVE-2020-8908
- jackson to 2.18.0 fixing CWE-400
- snakeyaml to 2.4 fixing CVE-2022-1471
djatnieks pushed a commit that referenced this pull request Apr 14, 2025
…ate cdc_enabled key in base yaml (#1680)

### What is the issue
#1563 upgraded our version of snakeyaml. This new version logs when
duplicate keys are found. The test-cdc target concatenates a
CDC-specific yaml to the base yaml. Both contain entries for the
cdc_enabled key, causing tests that load this yaml to log the warning.
This causes CDC CI failures.

### What does this PR fix and why was it fixed
This PR removes the cdc_enabled entry in the base yaml, as it's the same
as the default. This is consistent with how we handle other default keys
that might be duplicated across multiple yaml fragments in the test
commands.
djatnieks pushed a commit that referenced this pull request May 18, 2025
The customer requested an upgrade for some libraries (CVEs)

This PR upgrades to latest stable versions

- snappy to 1.1.10.7 fixing CVE-2023-43642
- guava to 33.4.0-jre fixing CVE-2023-2976 and CVE-2020-8908
- jackson to 2.18.0 fixing CWE-400
- snakeyaml to 2.4 fixing CVE-2022-1471
djatnieks pushed a commit that referenced this pull request May 18, 2025
…ate cdc_enabled key in base yaml (#1680)

### What is the issue
#1563 upgraded our version of snakeyaml. This new version logs when
duplicate keys are found. The test-cdc target concatenates a
CDC-specific yaml to the base yaml. Both contain entries for the
cdc_enabled key, causing tests that load this yaml to log the warning.
This causes CDC CI failures.

### What does this PR fix and why was it fixed
This PR removes the cdc_enabled entry in the base yaml, as it's the same
as the default. This is consistent with how we handle other default keys
that might be duplicated across multiple yaml fragments in the test
commands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants