- 
                Notifications
    You must be signed in to change notification settings 
- Fork 21
HCD-62 Upgrade of several libraries #1563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Checklist before you submit for review
 | 
7beea20    to
    ab80656      
    Compare
  
    | Note to self: The commit message will have to be amended before merge to reflect Guava stays at v29 | 
        
          
                test/distributed/org/apache/cassandra/distributed/test/FailingRepairTest.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | Please update the commit messages and pr description to list all the CVEs being fixed here. | 
f56bcca    to
    229cab9      
    Compare
  
    | @bereng could you rebase the PR to trigger the CI on the updated branch? | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good to me, I have left a few questions/comments.
        
          
                src/java/org/apache/cassandra/config/YamlConfigurationLoader.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      This commit contains the following upgrades * snappy to 1.1.10.7 fixing CVE-2023-43642 * guava to 33.4.0-jre fixing CVE-2023-2976 and CVE-2020-8908 * jackson to 2.18.0 fixing CWE-400 * snakeyaml to 2.4 fixing CVE-2022-1471
| 
 | 
| ❌ Build ds-cassandra-pr-gate/PR-1563 rejected by Butler1 new test failure(s) in 10 builds Found 1 new test failures
 Found 18 known test failures | 
…ate cdc_enabled key in base yaml (#1680) ### What is the issue #1563 upgraded our version of snakeyaml. This new version logs when duplicate keys are found. The test-cdc target concatenates a CDC-specific yaml to the base yaml. Both contain entries for the cdc_enabled key, causing tests that load this yaml to log the warning. This causes CDC CI failures. ### What does this PR fix and why was it fixed This PR removes the cdc_enabled entry in the base yaml, as it's the same as the default. This is consistent with how we handle other default keys that might be duplicated across multiple yaml fragments in the test commands.
The customer requested an upgrade for some libraries (CVEs) This PR upgrades to latest stable versions - snappy to 1.1.10.7 fixing CVE-2023-43642 - guava to 33.4.0-jre fixing CVE-2023-2976 and CVE-2020-8908 - jackson to 2.18.0 fixing CWE-400 - snakeyaml to 2.4 fixing CVE-2022-1471
…ate cdc_enabled key in base yaml (#1680) ### What is the issue #1563 upgraded our version of snakeyaml. This new version logs when duplicate keys are found. The test-cdc target concatenates a CDC-specific yaml to the base yaml. Both contain entries for the cdc_enabled key, causing tests that load this yaml to log the warning. This causes CDC CI failures. ### What does this PR fix and why was it fixed This PR removes the cdc_enabled entry in the base yaml, as it's the same as the default. This is consistent with how we handle other default keys that might be duplicated across multiple yaml fragments in the test commands.
The customer requested an upgrade for some libraries (CVEs) This PR upgrades to latest stable versions - snappy to 1.1.10.7 fixing CVE-2023-43642 - guava to 33.4.0-jre fixing CVE-2023-2976 and CVE-2020-8908 - jackson to 2.18.0 fixing CWE-400 - snakeyaml to 2.4 fixing CVE-2022-1471
…ate cdc_enabled key in base yaml (#1680) ### What is the issue #1563 upgraded our version of snakeyaml. This new version logs when duplicate keys are found. The test-cdc target concatenates a CDC-specific yaml to the base yaml. Both contain entries for the cdc_enabled key, causing tests that load this yaml to log the warning. This causes CDC CI failures. ### What does this PR fix and why was it fixed This PR removes the cdc_enabled entry in the base yaml, as it's the same as the default. This is consistent with how we handle other default keys that might be duplicated across multiple yaml fragments in the test commands.



What is the issue
The customer requested an upgrade for some libraries (CVEs)
What does this PR fix and why was it fixed
This PR upgrades to latest stable versions