Skip to content

Conversation

@jasonstack
Copy link

No description provided.

@github-actions
Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

@jasonstack jasonstack requested a review from eolivelli February 14, 2025 09:00
Copy link

@blambov blambov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to clarify somewhere what is the difference between a user compaction of some sstables vs a major compaction of the same sstables.

In the future we may also want to use the latter for user compactions (unless they have some "don't optimize" flag or something similar).

@sonarqubecloud
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1570 rejected by Butler


1 new test failure(s) in 4 builds
See build details here


Found 1 new test failures

Test Explanation Branch history Upstream history
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS... regression 🔴🔴🔵🔴 🔵🔵🔵🔵🔵🔵🔵

Found 11 known test failures

@jasonstack jasonstack merged commit 39cdaa2 into main Feb 18, 2025
465 of 475 checks passed
@jasonstack jasonstack deleted the cndb-12459-main branch February 18, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants