Skip to content

CNDB-12683 handle too long controller config file names (#1565) #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025
Merged

CNDB-12683 handle too long controller config file names (#1565) #1572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/java/org/apache/cassandra/db/compaction/unified/StaticController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.apache.cassandra.exceptions.ConfigurationException;
import org.apache.cassandra.io.util.File;
import org.apache.cassandra.io.util.FileReader;
import org.apache.cassandra.utils.JVMStabilityInspector;
import org.apache.cassandra.utils.MonotonicClock;
import org.apache.cassandra.utils.Overlaps;
import org.json.simple.JSONObject;
Expand Down Expand Up @@ -142,6 +143,11 @@ static Controller fromOptions(Environment env,
{
logger.warn("Unable to parse saved flush size. Using starting value instead:", e);
}
catch (Throwable e)
{
logger.warn("Unable to read controller config file. Using starting value instead:", e);
JVMStabilityInspector.inspectThrowable(e);
}
return new StaticController(env,
scalingParameters,
survivalFactors,
Expand Down
21 changes: 21 additions & 0 deletions test/unit/org/apache/cassandra/schema/CreateTableValidationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,13 @@
package org.apache.cassandra.schema;

import org.apache.cassandra.cql3.CQLTester;
import org.apache.cassandra.cql3.UntypedResultSet;
import org.apache.cassandra.exceptions.ConfigurationException;
import org.apache.cassandra.exceptions.InvalidRequestException;

import org.junit.Test;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
import static org.junit.Assert.fail;

Expand Down Expand Up @@ -100,6 +102,25 @@ public void testCreateTableWithMissingClusteringColumn()
"Missing CLUSTERING ORDER for column ck1");
}

@Test
public void testCreatingTableWithLongName() throws Throwable
{
String keyspace = "g38373639353166362d356631322d343864652d393063362d653862616534343165333764_tpch";
String table = "test_create_k8yq1r75bpzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz";

execute(String.format("CREATE KEYSPACE %s with replication = " +
"{ 'class' : 'SimpleStrategy', 'replication_factor' : 1 }",
keyspace));
createTableMayThrow(String.format("CREATE TABLE %s.%s (" +
"key int PRIMARY KEY," +
"val int)", keyspace, table));

execute(String.format("INSERT INTO %s.%s (key,val) VALUES (1,1)", keyspace, table));
flush(keyspace, table);
UntypedResultSet result = execute(String.format("SELECT * from %s.%s", keyspace, table));
assertThat(result.size()).isEqualTo(1);
}

private void expectedFailure(String statement, String errorMsg)
{

Expand Down
Loading