DSP-24615: Fix reading mmapped trie-index exceeding 2GiB #1574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
szymon-miezal
commented
Feb 18, 2025
|
Memory-mapping is done in buffers of size less than 2GiB. When these buffers aren't aligned to 4KiB and the trie-index file spans many buffers then reading it results in going out of buffer bounds. This patch fixes it by making sure that the buffers are correctly aliged.
szymon-miezal
force-pushed
the
DSP-24615
branch
from
6a857dc to
d26d720
Compare
szymon-miezal
changed the title
❌ Build ds-cassandra-pr-gate/PR-1574 rejected by Butler1 new test failure(s) in 3 builds Found 1 new test failures
Found 6 known test failures |
blambov
approved these changes
Feb 18, 2025
szymon-miezal
added a commit
that referenced
this pull request
Feb 19, 2025
### What is the issue Memory-mapping is done in buffers of size less than 2GiB. When these buffers aren't aligned to 4KiB and the trie-index file spans many buffers then reading it results in going out of buffer bounds. ### What does this PR fix and why was it fixed This patch fixes it by making sure that the buffers are correctly aligned.
djatnieks
pushed a commit
that referenced
this pull request
Mar 11, 2025
Memory-mapping is done in buffers of size less than 2GiB. When these buffers aren't aligned to 4KiB and the trie-index file spans many buffers then reading it results in going out of buffer bounds. This patch fixes it by making sure that the buffers are correctly aligned.
djatnieks
pushed a commit
that referenced
this pull request
May 18, 2025
Memory-mapping is done in buffers of size less than 2GiB. When these buffers aren't aligned to 4KiB and the trie-index file spans many buffers then reading it results in going out of buffer bounds. This patch fixes it by making sure that the buffers are correctly aligned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
Memory-mapping is done in buffers of size less than 2GiB.
When these buffers aren't aligned to 4KiB and the trie-index file
spans many buffers then reading it results in going out of buffer bounds.
What does this PR fix and why was it fixed
This patch fixes it by making sure that the buffers are correctly aligned.