CNDB-13004 don't fail on too long file name for options #1576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
eolivelli
approved these changes
Feb 17, 2025
|
@eolivelli I found another related bug and extended the fix with it. It's in |
k-rus
changed the title
jtgrabowski
reviewed
Feb 18, 2025
src/java/org/apache/cassandra/db/compaction/unified/AdaptiveController.java
Outdated
Show resolved
Hide resolved
When a compaction controller config options are being written for a table with long keyspace + table names, FileSystemException happens. This commit fixes that such exception is caught and logged. Thus existing table with long name will continue to function.
k-rus
force-pushed
the
rf-cndb-13004-store-options-write
branch
from
47b95a5 to
0152e0a
Compare
|
❌ Build ds-cassandra-pr-gate/PR-1576 rejected by Butler1 new test failure(s) in 6 builds Found 1 new test failures
Found 14 known test failures |
jtgrabowski
approved these changes
Feb 18, 2025
k-rus
added a commit
that referenced
this pull request
Feb 18, 2025
When a compaction controller config options are being written or read for a table with long keyspace + table names, FileSystemException happens. This commit fixes that such exception is caught and logged. Thus existing table with long name will continue to function. Tests are added. Also it catches other exceptions.
k-rus
added a commit
that referenced
this pull request
Feb 19, 2025
When a compaction controller config options are being written or read for a table with long keyspace + table names, FileSystemException happens. This commit fixes that such exception is caught and logged. Thus existing table with long name will continue to function. Tests are added. Also it catches other exceptions.
djatnieks
pushed a commit
that referenced
this pull request
Mar 11, 2025
When a compaction controller config options are being written or read for a table with long keyspace + table names, FileSystemException happens. This commit fixes that such exception is caught and logged. Thus existing table with long name will continue to function. Tests are added. Also it catches other exceptions.
djatnieks
pushed a commit
that referenced
this pull request
May 18, 2025
When a compaction controller config options are being written or read for a table with long keyspace + table names, FileSystemException happens. This commit fixes that such exception is caught and logged. Thus existing table with long name will continue to function. Tests are added. Also it catches other exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13004
What is the issue
When a compaction controller config options are being written or read for a table with long keyspace + table names, FileSystemException happens.
What does this PR fix and why was it fixed
This commit fixes that such exception is caught and logged. Thus existing table with long name will continue to function. Tests are added.
Also it catches other exceptions.