CNDB-12981: Revert ADA002 VectorSourceModel change to BINARY_QUANTIZATION #1580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
|
✔️ Build ds-cassandra-pr-gate/PR-1580 approved by ButlerApproved by Butler |
michaeljmarshall
approved these changes
Feb 19, 2025
djatnieks
pushed a commit
that referenced
this pull request
Mar 11, 2025
…TION (#1580) CNDB-12981: Revert ADA002 VectorSourceModel change to BINARY_QUANTIZATION Reverting the change to BINARY_QUANTIZATION from PRODUCT_QUANTIZATION. A simple change to VectorSourceModel. Ensures that both new and existing indexes the using the ada002 embedding model continue to use PQ for now. All of the other changes that were originally committed with it in 655080c remain intact.
djatnieks
pushed a commit
that referenced
this pull request
May 18, 2025
…TION (#1580) CNDB-12981: Revert ADA002 VectorSourceModel change to BINARY_QUANTIZATION Reverting the change to BINARY_QUANTIZATION from PRODUCT_QUANTIZATION. A simple change to VectorSourceModel. Ensures that both new and existing indexes the using the ada002 embedding model continue to use PQ for now. All of the other changes that were originally committed with it in 655080c remain intact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNDB-12981: Revert ADA002 VectorSourceModel change to BINARY_QUANTIZATION
Reverting the change to BINARY_QUANTIZATION from PRODUCT_QUANTIZATION. A simple change to VectorSourceModel.
Ensures that both new and existing indexes the using the ada002 embedding model continue to use PQ for now. All of the other changes that were originally committed with it in 655080c remain intact.