HCD-83 Enables IAuthenticator's to return own AuthenticateMessage #1582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows custom implementations of IAuthenticator to return their own AuthenticateMessage based on ClientState information. ClientState contains information about driver's name and version which could be used to determine the contents of the AuthenticateMessage that is sent back to the clients. This enables, for instance, returning driver's known authenticator implementations (e.g. DseAuthenticator) which enables SASL negotiation. patch by Tiago Alves; reviewed by Mick Semb Wever, Andy Tolbert for CASSANDRA-19984
Checklist before you submit for review
|
|
❌ Build ds-cassandra-pr-gate/PR-1582 rejected by Butler1 new test failure(s) in 1 builds Found 1 new test failures
Found 8 known test failures |
emerkle826
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
This looks good to me (looks like almost a direct port of apache@8bf354b for Cassandra 5.0)
jacek-lewandowski
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
ClientState contains information about driver's name and version which could be used to determine the contents of the AuthenticateMessage that is sent back to the clients. This enables, for instance, returning driver's known authenticator implementations (e.g. DseAuthenticator) which enables SASL negotiation.
What does this PR fix and why was it fixed
Allows custom implementations of IAuthenticator to return their own AuthenticateMessage based on ClientState information.
This PR back-ports CASSANDRA-19984.