Skip to content

Conversation

@adelapena
Copy link

Fix RowFilter application of analyzers to queries on collections.

RowFilter.SimpleExpression#isSatisfiedBy for CONTAINS and CONTAINS_KEY operators should extract the collection values and check them with Operator.ANALYZER_MATCHES rather than with equality.

@adelapena adelapena self-assigned this Feb 19, 2025
@sonarqubecloud
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1585 rejected by Butler


4 new test failure(s) in 1 builds
See build details here


Found 4 new test failures

Test Explanation Branch history Upstream history
t.TestCqlshUnicode.test_unicode_identifier regression 🔴
...al,decimal>,wide=false,scenario=MEMTABLE_QUERY] regression 🔴
...t.testKDTreePostingsQueryMetricsWithSingleIndex regression 🔴
o.a.c.i.c.CQLCompressionTest.lz4FlushTest regression 🔴

No known test failures found

Copy link

@ekaterinadimitrova2 ekaterinadimitrova2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like flaky tests not related to what we do here, which we need to open tickets for.
@michaeljmarshall ?
Also same comments about the test coverage as in the other PR - #1583

Do we have baseline CI run for this branch? --> checked in Slack, we don't so I was trying to look into Jenkins for main branch

Copy link

@ekaterinadimitrova2 ekaterinadimitrova2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on the condition @adelapena , @michaeljmarshall or anyone else checks the flaky CI results too.

@eolivelli
Copy link

the 4 failures are not related to this patch

@adelapena adelapena merged commit feecd2d into cndb-main-release-202501 Feb 20, 2025
463 of 473 checks passed
@adelapena adelapena deleted the CNDB-13022-cndb-main-release-202501 branch February 20, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants