Skip to content

Conversation

@tiagomlalves
Copy link
Member

What is the issue

PR #1578 caused failures elsewhere and needed to be reverted.
This adds back changes after fixing those failures.

What does this PR fix and why was it fixed

This reverts commit b6930b5 adding back #1578

@github-actions
Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

@tiagomlalves tiagomlalves marked this pull request as ready for review February 25, 2025 23:10
@sonarqubecloud
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1608 rejected by Butler


1 new test failure(s) in 1 builds
See build details here


Found 1 new test failures

Test Explanation Branch history Upstream history
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS... regression 🔴 🔵🔵🔵🔵🔵🔵🔵

Found 1 known test failures

Copy link

@jacek-lewandowski jacek-lewandowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, based on the previous approval

@tiagomlalves tiagomlalves merged commit 72b6722 into main Feb 27, 2025
470 of 476 checks passed
@tiagomlalves tiagomlalves deleted the HCD-82-v2 branch February 27, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants