-
Notifications
You must be signed in to change notification settings - Fork 21
CNDB-13074: Reject analysis options on frozen collections #1610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Checklist before you submit for review
|
a371a16 to
8ce2aa5
Compare
|
PR for CNDB: https://github.com/riptano/cndb/pull/13152 |
8ce2aa5 to
d8e72f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the column name (or at least the type) to the message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
d8e72f4 to
5a4b3b2
Compare
5a4b3b2 to
a3acd44
Compare
|
❌ Build ds-cassandra-pr-gate/PR-1610 rejected by Butler1 new test failure(s) in 3 builds Found 1 new test failures
Found 2 known test failures |
Reject creating indexes with analysis options on frozen collections. We don't have a way to correctly index them, and we don't support querying either.
Reject creating indexes with analysis options on frozen collections. We don't have a way to correctly index them, and we don't support querying either.



It's not allowed to create an index with non-Lucene analysis options on a frozen collection. For example:
This IMO makes sense because it won't support any meaningful operator. However, we don't get that rejection if we try to specify an
index_analyzer. For example:In this case, the entire serialized collection is treated as a single string and analyzed. This interpretation of the serialized collection as a string includes the metadata at the beginning, it doesn't use any kind of token separators between fields, etc., so it ends up as a bunch of non-printable characters.
This PR simply rejects creating indexes with analysis options on frozen collections, given that we don't have a way to correctly index them, and we don't support querying either.