-
Notifications
You must be signed in to change notification settings - Fork 21
HCD-84 Feature flag to skip Ford Fulkerson #1612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Checklist before you submit for review
|
78179c7 to
e4ca74b
Compare
e4ca74b to
58d5525
Compare
|
This has been tested with the approach of skipping when vnodes>1 and Butler was happy with it. Ci run here This has been tested with the FF deactivated and Butler is happy with it CI here. Where the only failure is a known one. As we can see below with the FF enabled all is good as that failures passes locally |
szymon-miezal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving +1, I have left two rename suggestions in tests for your consideration, they aren't major. I have also left one remark about config property resetting - that one I think should be addressed before merging.
This commit introduces "com.datastax.RangeStreamer.skipFFOptimization" as a feature flag system property to disable the FF optimization when calculating ranges for certain operations causing slowdowns.
3527a95 to
451fd4b
Compare
|
Squashed, rebased, sanity tests ran locally and merged. |
The Ford Fulkerson optimization may take too long in some configs Some configs make the FF computation take too long This PR adds a feature flag so you can workaround it
|
❌ Build ds-cassandra-pr-gate/PR-1612 rejected by Butler1 new test failure(s) in 8 builds Found 1 new test failures
Found 9 known test failures |
The Ford Fulkerson optimization may take too long in some configs Some configs make the FF computation take too long This PR adds a feature flag so you can workaround it
The Ford Fulkerson optimization may take too long in some configs Some configs make the FF computation take too long This PR adds a feature flag so you can workaround it



The Ford Fulkerson optimization may take too long in some configs
What is the issue
Some configs make the FF computation take too long
What does this PR fix and why was it fixed
This PR adds a feature flag so you can workaround it