Skip to content

Conversation

@jasonstack
Copy link

No description provided.

@github-actions
Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add unit tests about this method, it is easy to forget edge cases or introduce regressions in the future

we can probably have a static method that does the path handling, so that doing unit tests is easier

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added basic unit test in cc. I will add more in CNDB side with remote file system

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
57.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@cassci-bot
Copy link

✔️ Build ds-cassandra-pr-gate/PR-1613 approved by Butler


Approved by Butler
See build details here

@jasonstack
Copy link
Author

There is new approach in CNDB without relying parent directory's file system. Will close this PR as won't fix.

@jasonstack jasonstack closed this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants