CNDB-13171: Fix query_filters guardrail using the index analyzer instead of the query analyzer #1615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
adelapena
force-pushed
the
CNDB-13171-main
branch
from
343205d to
6b5550f
Compare
pkolaczk
approved these changes
Mar 10, 2025
…ead of the query analyzer
adelapena
force-pushed
the
CNDB-13171-main
branch
from
6b5550f to
97685d4
Compare
|
✔️ Build ds-cassandra-pr-gate/PR-1615 approved by ButlerApproved by Butler |
djatnieks
pushed a commit
that referenced
this pull request
Apr 14, 2025
…ead of the query analyzer (#1615) Fix `RowFilter.AnalyzableExpression#numFilteredValues`, which is used by the `query_filters` guardrail, to use the query analyzer, instead of the index analyzer. That prevents wrong triggerings of the guardrail.
djatnieks
pushed a commit
that referenced
this pull request
May 18, 2025
…ead of the query analyzer (#1615) Fix `RowFilter.AnalyzableExpression#numFilteredValues`, which is used by the `query_filters` guardrail, to use the query analyzer, instead of the index analyzer. That prevents wrong triggerings of the guardrail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
RowFilter.AnalyzableExpression#numFilteredValues, which is used by thequery_filtersguardrail, uses the index analyzer, whereas it should use the query analyzer. This could lead to wrongly triggering the guardrail in some cases.