HCD-73: Add a jmx endpoint to change the node state in gossip #1617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
szymon-miezal
changed the title
Collaborator
|
LGTM and I don't think we need a CNDB PR here as it's just adding some JMX methods. +1 |
bereng
approved these changes
Mar 6, 2025
|
✔️ Build ds-cassandra-pr-gate/PR-1617 approved by ButlerApproved by Butler |
Author
|
It seems that Sonar Qube complains about the lack of coverage as it fails to process the addition of a dtest 😞. |
szymon-miezal
added a commit
that referenced
this pull request
Mar 6, 2025
### What is the issue Node crashes during node replacements result in hibernated nodes that cannot join the cluster anymore due to a lack of SYN messages from seeds. ### What does this PR fix and why was it fixed Port DB-1482, which allows the use a jmx endpoint on a seed to bring the hibernated node back to the gossiping candidate list. Tested via: datastax/cassandra-dtest#75.
djatnieks
pushed a commit
that referenced
this pull request
Mar 11, 2025
Node crashes during node replacements result in hibernated nodes that cannot join the cluster anymore due to a lack of SYN messages from seeds. Port DB-1482, which allows the use a jmx endpoint on a seed to bring the hibernated node back to the gossiping candidate list. Tested via: datastax/cassandra-dtest#75.
djatnieks
pushed a commit
that referenced
this pull request
May 18, 2025
Node crashes during node replacements result in hibernated nodes that cannot join the cluster anymore due to a lack of SYN messages from seeds. Port DB-1482, which allows the use a jmx endpoint on a seed to bring the hibernated node back to the gossiping candidate list. Tested via: datastax/cassandra-dtest#75.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
Node crashes during node replacements result in hibernated nodes that cannot join the cluster anymore due to lack of SYN messages from seeds.
What does this PR fix and why was it fixed
Port DB-1482 which allows to use a jmx endpoint on a seed to bring the hibernated node back to the gossip candidate list.
Tested via: datastax/cassandra-dtest#75.
https://jenkins-stargazer.aws.dsinternal.org/job/ds-cassandra-pr-gate/view/change-requests/job/PR-1617/3/testReport/dtest-offheap-bti.replace_address_test/TestReplaceAddress/tests_stage_2___dtests___dtest_offheap_bti___dtest_offheap_bti_14___test_revive_endpoint/