CNDB-13196: Fix BM25 file access race condition #1622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were incorrectly sharing a file reader across threads, which can lead to invalid results, as the test shows.
Checklist before you submit for review
|
adelapena
approved these changes
Mar 7, 2025
adelapena
left a comment
adelapena
left a comment
There was a problem hiding this comment.
Looks good to me. I have only left a couple of suggestions that can be addressed on commit.
The primary goal here is to increase the probability of hitting the race. It seems it still isn't perfect, but anecdotally, we hit it frequently on my machine. Further, this kind of bug is not hard to see, so I don't think it is worth further time trying to make a perfect test.
|
✔️ Build ds-cassandra-pr-gate/PR-1622 approved by ButlerApproved by Butler |
djatnieks
pushed a commit
that referenced
this pull request
Mar 11, 2025
Fixes: riptano/cndb#13196 We were incorrectly sharing a file reader across threads in BM25 queries, which can lead to invalid results, as I reproduced in the test. The PR fixes the issue by creating a `DocLengthsReader` object per query.
djatnieks
pushed a commit
that referenced
this pull request
May 18, 2025
Fixes: riptano/cndb#13196 We were incorrectly sharing a file reader across threads in BM25 queries, which can lead to invalid results, as I reproduced in the test. The PR fixes the issue by creating a `DocLengthsReader` object per query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/riptano/cndb/issues/13196
What is the issue
We were incorrectly sharing a file reader across threads in BM25 queries, which can lead to invalid results, as I reproduced in the test.
What does this PR fix and why was it fixed
The PR fixes the issue by creating a
DocLengthsReaderobject per query.