-
Notifications
You must be signed in to change notification settings - Fork 21
HCD-109 Deserialise dse 6.8 PeerInfo files #1632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Checklist before you submit for review
|
1dfd4ba to
97eac22
Compare
311077f to
e0730e9
Compare
szymon-miezal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, a small reminder to not miss the commit message while merging - in the CC repo the commit message is taken from the PR description by default, which is empty now.
e0730e9 to
c192340
Compare
InetAddressAndPort fields were previously InetAddress, and serialised as either byte[] addresses or text hostnames. Adds two unit tests, simple serdes of InetAddress to InetAddressAndPort, and parsing of DSE-6 files (kept in `test/data/legacy-metadata/dse-6.8/nodes`).
c192340 to
31ae0a9
Compare
|
❌ Build ds-cassandra-pr-gate/PR-1632 rejected by Butler1 new test failure(s) in 4 builds Found 1 new test failures
Found 6 known test failures |
|
the test regression needs inspection… |
|
Seems like it occasionally fails on |



InetAddressAndPort fields were previously InetAddress, and serialised as either byte[] addresses or text hostnames.
Adds two unit tests, simple serdes of InetAddress to InetAddressAndPort, and parsing of DSE-6 files (kept in
test/data/legacy-metadata/dse-6.8/nodes).