Skip to content

Conversation

@michaelsembwever
Copy link
Member

@michaelsembwever michaelsembwever commented Mar 13, 2025

InetAddressAndPort fields were previously InetAddress, and serialised as either byte[] addresses or text hostnames.

Adds two unit tests, simple serdes of InetAddress to InetAddressAndPort, and parsing of DSE-6 files (kept in test/data/legacy-metadata/dse-6.8/nodes).

@github-actions
Copy link

github-actions bot commented Mar 13, 2025

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

@michaelsembwever michaelsembwever changed the title Hcd 109 mck main HCD-109 Deserialise dse 6.8 PeerInfo files Mar 13, 2025
@michaelsembwever michaelsembwever force-pushed the HCD-109-mck-main branch 4 times, most recently from 311077f to e0730e9 Compare March 16, 2025 12:48
@michaelsembwever michaelsembwever marked this pull request as ready for review March 16, 2025 12:50
Copy link

@szymon-miezal szymon-miezal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, a small reminder to not miss the commit message while merging - in the CC repo the commit message is taken from the PR description by default, which is empty now.

InetAddressAndPort fields were previously InetAddress, and serialised as either byte[] addresses or text hostnames.

Adds two unit tests, simple serdes of InetAddress to InetAddressAndPort, and parsing of DSE-6 files (kept in `test/data/legacy-metadata/dse-6.8/nodes`).
@sonarqubecloud
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1632 rejected by Butler


1 new test failure(s) in 4 builds
See build details here


Found 1 new test failures

Test Explanation Branch history Upstream history
...testWithRangeTombstoneMarkersWithoutCompression regression 🔴🔴🔴🔵 🔵🔵🔵🔵🔵🔵🔵

Found 6 known test failures

@michaelsembwever
Copy link
Member Author

the test regression needs inspection…

@szymon-miezal
Copy link

Seems like it occasionally fails on main as well, example: https://jenkins-stargazer.aws.dsinternal.org/job/ds-cassandra-build-fast-ci/1751/testReport/org.apache.cassandra.io.sstable.format/SSTableFlushObserverTest/.

@michaelsembwever michaelsembwever merged commit 4948d69 into main Mar 19, 2025
472 of 478 checks passed
@michaelsembwever michaelsembwever deleted the HCD-109-mck-main branch March 19, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants