CNDB-13299 prevent too long index names #1633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
eolivelli
reviewed
Mar 14, 2025
There was a problem hiding this comment.
IIRC the file names are the result of the concatenation of the keyspace and tablename and the indexname, why don't we consider tableName.length() + keyspaceName.length() here ?
Member
Author
There was a problem hiding this comment.
No, file names for indexes do not use keyspace and table names when an index name is explicitly given. See the discussion in the issue.
eolivelli
reviewed
Mar 14, 2025
src/java/org/apache/cassandra/cql3/statements/schema/CreateIndexStatement.java
Outdated
Show resolved
Hide resolved
k-rus
force-pushed
the
rf-cndb-13299-long-index-name
branch
from
09d48cd to
136c691
Compare
|
❌ Build ds-cassandra-pr-gate/PR-1633 rejected by Butler1 new test failure(s) in 4 builds Found 1 new test failures
Found 32 known test failures |
eolivelli
approved these changes
Mar 19, 2025
k-rus
changed the title
djatnieks
pushed a commit
that referenced
this pull request
Apr 14, 2025
Creating an index with too long index names leads to file errors or incorrect results. This PR prevents creating new indexes, i.e., not internal, with provided index names longer than 182 characters. This constant is based on the most restrictive requirement from different index types. It comes from SAI by subtracting the longest file name addition from the file name limit of 255 characters.
djatnieks
pushed a commit
that referenced
this pull request
May 18, 2025
Creating an index with too long index names leads to file errors or incorrect results. This PR prevents creating new indexes, i.e., not internal, with provided index names longer than 182 characters. This constant is based on the most restrictive requirement from different index types. It comes from SAI by subtracting the longest file name addition from the file name limit of 255 characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
Fixes https://github.com/riptano/cndb/issues/13299
Creating an index with too long index names leads to file errors or incorrect results.
What does this PR fix and why was it fixed
This PR prevents creating new indexes, i.e., not internal, with provided index names longer than 182 characters. This constant is based on the most restrictive requirement from different index types. It comes from SAI by subtracting the longest file name addition from the file name limit of 255 characters.