CNDB-15156: Include actual number of cached rows above threshold in RFP warn #1959
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



ReplicaFilteringProtectionhas a very useful log message saying when a query has collected more than a certain configurable number of rows, 2000 by default, here:This message has been very useful while investigating incidents because it has allowed us to identify which specific queries were returning many rows. The only thing that we missed is that it didn't say exactly how many rows were returned. While we can have metrics for that, it would be useful if this log message also included the specific number of rows.
This PR includes the number of rows cached by RFP when it exceeds either its warning or failure threshold. For this, the warning threshold check is moved to the end of the query, so we can report the maximum number of cached rows just once.