CNDB-13408 Improve BM25 test with better logic #1963
Conversation
Code to generate collection values for BM25 test is difficult to follow. This commit refactors the generation code into methods with simpler code. Also this commit removes unused last column in the dataset.
Checklist before you submit for review
|
|
❌ Build ds-cassandra-pr-gate/PR-1963 rejected by Butler1 regressions found Found 1 new test failures
No known test failures found |
ekaterinadimitrova2
requested review from
ekaterinadimitrova2
and removed request for
a team
There was a problem hiding this comment.
Looks good to me. Left two small comments which are a matter of taste and personal opinion so you don't have to act on them if you don't want to. Nothing too important.
The only failed test is unrelated for sure as you are refactoring completely different test.
Fine by me if you want to commit this as-is.
| public static void insertCollectionData(SAITester tester) | ||
| { | ||
| int setsize = 1; | ||
| for (int row = 0; row < DATASET.length; row++) |
There was a problem hiding this comment.
I would have probably kept the brace considering the multiline statement, but it is a matter of personal taste. I do not insist on adding anything; I am just expressing my opinion.
There was a problem hiding this comment.
I would prefer a better indentation rule inside parentheses.
|
|
||
| public final static Object[][] DATASET = | ||
| { | ||
| { 0, "Climate", 5, "Climate change is a pressing issue. Climate patterns are shifting globally. Scientists study climate data daily.", 1 }, |
There was a problem hiding this comment.
This commit is for cleaning/refactoring, why not remove the last two IDE warnings in the test class, too?
There was a problem hiding this comment.
I am actually not sure about fixing the warnings. Removing the result type will make the method signature inconsistent.
The second case is on purpose.
Code to generate collection values for BM25 test is difficult to follow. This commit refactors the generation code into methods with simpler code. Also this commit removes unused last column in the dataset.
Code to generate collection values for BM25 test is difficult to follow. This commit refactors the generation code into methods with simpler code. Also this commit removes unused last column in the dataset.
Code to generate collection values for BM25 test is difficult to follow. This commit refactors the generation code into methods with simpler code. Also this commit removes unused last column in the dataset.
The changes were originally implemented in https://github.com/riptano/cndb/pull/13443