Skip to content

Conversation

@adelapena
Copy link

Add ALLOW FILTERING to AbstractReadQuery#toCQLString.

This makes the output of toCQLString a bit more distracting, but with the possible benefit of guaranteeing that the output of that method is always runnable. This is the ASF behaviour, for good or for worse.

@github-actions
Copy link

github-actions bot commented Sep 1, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@driftx
Copy link

driftx commented Sep 2, 2025

Adding AF everywhere is what it is, but that works for me.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2025

@cassci-bot
Copy link

✔️ Build ds-cassandra-pr-gate/PR-1974 approved by Butler


Approved by Butler
See build details here

@adelapena adelapena merged commit ab17081 into main Sep 5, 2025
489 of 495 checks passed
@adelapena adelapena deleted the CNDB-15239-main branch September 5, 2025 14:23
djatnieks pushed a commit that referenced this pull request Sep 7, 2025
This makes the output of toCQLString a bit more distracting because AF is not always needed,
but it aligns with ASF and it guarantees that the output of that method is always runnable.
djatnieks pushed a commit that referenced this pull request Sep 9, 2025
This makes the output of toCQLString a bit more distracting because AF is not always needed,
but it aligns with ASF and it guarantees that the output of that method is always runnable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants