Skip to content

Conversation

@djatnieks
Copy link

Code to generate collection values for BM25 test is difficult to follow. This commit refactors the generation code into methods with simpler code. Also this commit removes unused last column in the dataset.

Code to generate collection values for BM25 test is difficult to follow.
This commit refactors the generation code into methods with simpler
code. Also this commit removes unused last column in the dataset.
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@djatnieks djatnieks requested a review from driftx September 3, 2025 13:44
Copy link

@driftx driftx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I recall there are already some failing BM25 tests, maybe this will help.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2025

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1977 rejected by Butler


1 regressions found
See build details here


Found 1 new test failures

Test Explanation Runs Upstream
o.a.c.distributed.test.repair.ForceRepairTest.forceWithDifference () REGRESSION 🔴 1 / 2

Found 11 known test failures

@djatnieks djatnieks merged commit e230c7a into main-5.0 Sep 4, 2025
573 of 587 checks passed
@djatnieks djatnieks deleted the CNDB-15264 branch September 4, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants