CNDB-15469: Implement NVQ for vector graphs built by compaction #2030
+248
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
michaeljmarshall
force-pushed
the
cndb-15469
branch
3 times, most recently
from
46dddfb to
97aa041
Compare
michaeljmarshall
force-pushed
the
cndb-15469
branch
from
97aa041 to
599a119
Compare
NVQ was added as part of jvector's on disk file version 4. We have SAI versioning that properly handles the read/write upgrade implications, so it is safe to use the jvector file format version as the gate in addition to the boolean flag.
michaeljmarshall
force-pushed
the
cndb-15469
branch
from
599a119 to
12ab1c0
Compare
| // Use non-positive value to disable it. Period in millis to trigger a flush for SAI vector memtable index. | ||
| SAI_VECTOR_FLUSH_PERIOD_IN_MILLIS("cassandra.sai.vector_flush_period_in_millis", "-1"), | ||
| // Use nvq when building graphs in compaction | ||
| SAI_VECTOR_ENABLE_NVQ("cassandra.sai.vector.enable_nvq", "true"), |
There was a problem hiding this comment.
Talked with Ted and Mariano, it is not time to enable by default yet.
There was a problem hiding this comment.
We might want to push it through as an index option that is disabled by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
Fixes: https://github.com/riptano/cndb/issues/15469
What does this PR fix and why was it fixed
This is a draft and is not yet complete.
The main open questions come from how to store vectors in an addressable way so that we can iterate them and write them to the correct location. Saving this as a draft to prevent the work from getting lost.