Skip to content

Conversation

@djatnieks
Copy link

What is the issue

Fixes CNDB-15569

What does this PR fix and why was it fixed

Reverts most of CNDB-11311 that was not necessary and caused problems in CNDB due to changes in where and when SSTableWatcher.instance.discoverComponents is called.

@djatnieks djatnieks requested a review from driftx October 3, 2025 17:03
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@driftx
Copy link

driftx commented Oct 7, 2025

As you know, we still need CNDB-15526. I did a test of just adding the "except TOCComponent" SSTableReader line, and that unsurprisingly works too but confirms that's what's important here.

@djatnieks djatnieks merged commit c02813d into main-5.0 Oct 10, 2025
509 of 523 checks passed
@djatnieks djatnieks deleted the CNDB-15569 branch October 10, 2025 20:25
@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2034 rejected by Butler


1 regressions found
See build details here


Found 1 new test failures

Test Explanation Runs Upstream
o.a.c.cql3.validation.operations.AggregationQueriesTest.testAggregationQueryShouldNotTimeoutWhenItExceedesReadTimeout (compression) REGRESSION 🔴🔴 2 / 10

Found 4 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants