Skip to content

Conversation

k-rus
Copy link

@k-rus k-rus commented Oct 9, 2025

At least this PR needs some polishing.
Disk size of SAI files is unstable in AA and different sized were noticed. Hopefully the current bound is large enough to not produce flakiness. Are there better suggestions to deal with varying size?
Will it be good idea to set a low bound, so the expected number are more meaningful?

I think to postpone vector and analyzed SAI as the current priority is SAI on traditional columns.

What is the issue

Switchin to EC significantly increased size of SAI files. This wasn't expected and created incidents.

What does this PR fix and why was it fixed

Fixes https://github.com/riptano/cndb/issues/15609

Adds tests to control SAI disk size for different format version and different partition sizes.
It uses expected size as upper bound.
The actual sizes are logged during test executions.
This also should help to see improvements in #15608 .

Copy link

github-actions bot commented Oct 9, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

Add tests to control SAI disk size for different format version and
different partition sizes.
@k-rus k-rus force-pushed the rf-15609-test-sai-size branch from 15ae0dc to ef2df5d Compare October 10, 2025 08:47
Copy link

@cassci-bot
Copy link

✔️ Build ds-cassandra-pr-gate/PR-2045 approved by Butler


Approved by Butler
See build details here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants