Skip to content

Conversation

maxtomassi
Copy link

Port of #2043 into cndb-main-release-202505

What is the issue

Repairs use the local write path for streams on CDC-enabled tables, based on table schema. This interacts poorly with the separation of CNDB services.

What does this PR fix and why was it fixed

Only use the CDC write path for a stream if CDC is enabled in the node's configuration (as well as in the schema). This avoids attempting to use the local write path if commitlog-based CDC is not enabled.

…iver if CDC is enabled on the node (#2043)

Repairs use the local write path for streams on CDC-enabled tables,
based on table schema. This interacts poorly with the separation of CNDB
services.

This commit fixes the issue by only using the CDC write path for a stream if CDC 
is enabled in the node's configuration (as well as in the schema). This avoids 
attempting to use the local write path if commitlog-based CDC is not enabled.
Copy link

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2061 rejected by Butler


4 regressions found
See build details here


Found 4 new test failures

Test Explanation Runs Upstream
o.a.c.db.compaction.unified.ShardedMultiWriterTest.testShardedCompactionWriter_fiveShards[isReplicaAware=true] (compression) NEW 🔴 0 / 0
o.a.c.distributed.test.repair.ConcurrentValidationRequestsTest.testConcurrentValidations NEW 🔴 0 / 0
o.a.c.net.ConnectionTest.testCRCCorruption (compression) NEW 🔴 0 / 0
o.a.c.utils.binlog.BinLogTest.testTruncationReleasesLogSpace (compression) NEW 🔴 0 / 0

No known test failures found

@maxtomassi maxtomassi merged commit f677c54 into cndb-main-release-202505 Oct 10, 2025
480 of 490 checks passed
@maxtomassi maxtomassi deleted the CNDB-15623-cndb-main-release-202505 branch October 10, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants