Skip to content

Conversation

adelapena
Copy link

What is the issue

See https://github.com/riptano/cndb/issues/15619

What does this PR fix and why was it fixed

There is a new cassandra.sai.version.selector.class system property allowing to provide an implementation of the o.a.c.index.sai.disk.format.Version.Selector interface to specify that version of the SAI on-disk index format should be used for each keyspace.

This is a cherry-pick of #2041

… current() depending on a keyspace

There is a new cassandra.sai.version.selector.class system property allowing
to provide an implementation of the o.a.c.index.sai.disk.format.Version.Selector
interface to specify that version of the SAI on-disk index format should be
used for each keyspace.
@adelapena adelapena self-assigned this Oct 15, 2025
Copy link

github-actions bot commented Oct 15, 2025

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2064 rejected by Butler


2 regressions found
See build details here


Found 2 new test failures

Test Explanation Runs Upstream
paxos_test.TestPaxos.test_contention_many_threads (offheap-bti) NEW 🔴 0 / 0
o.a.c.db.counters.CounterLockManagerTest.testInterruptedExceptionCachedCounterLockManager (compression) NEW 🔴 0 / 0

No known test failures found

@adelapena
Copy link
Author

@pcmanus @eolivelli could you please review this port of #2041 ?

Copy link

@pcmanus pcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@adelapena adelapena merged commit ad7662a into cndb-main-release-202505 Oct 16, 2025
478 of 488 checks passed
@adelapena adelapena deleted the CNDB-15619-main-release-202505-sai-per-tenant branch October 16, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants