Skip to content

Conversation

blambov
Copy link

@blambov blambov commented Oct 16, 2025

What is the issue

HCD-209

Early open SSTables created when an sstable is complete, but the whole compaction isn't, were not properly set up because of a missing updateFileHandle call in openFinalEarly.

What does this PR fix and why was it fixed

Add the missing update and changes updateFileHandle to also take care of the file length to clarify all file handle updates.

Also includes fix for CASSANDRA-20976 (partially-built indexes were not properly copied with sharedCopy).

Copy link

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@blambov blambov requested a review from szymon-miezal October 17, 2025 10:03
Change updateFileHandle to also take care of the file length

Also includes fix for CASSANDRA-20976
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2068 rejected by Butler


1 regressions found
See build details here


Found 1 new test failures

Test Explanation Runs Upstream
o.a.c.index.sai.cql.VectorKeyRestrictedOnPartitionTest.partitionRestrictedWidePartitionBqCompressedTest[db] (compression) REGRESSION 🔴🔵 0 / 10

Found 8 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants