Skip to content

Conversation

adelapena
Copy link

What is the issue

Vector index creation when index version is earlier than Version.JVECTOR_EARLIEST (CA) fail asynchronously. We want to validate CREATE INDEX statements against the local index version so we can make these statement fail synchronously, before the index build is started and the schema is altered.

What does this PR fix and why was it fixed

This patch makes vector index creation statements fail depending on the local index version. If the local node has the right version but any of the remotes doesn't, the failure will remain asynchronous.

These index creations would usually fail in the asynchronous build.
This patch makes them fail synchronously at CREATE INDEX depending on the local index version.
If the local node has the right version but any of the remotes doesn't, the failure will remain
asynchronous.
@adelapena adelapena self-assigned this Oct 17, 2025
Copy link

github-actions bot commented Oct 17, 2025

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@adelapena adelapena requested a review from eolivelli October 17, 2025 13:29
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2072 rejected by Butler


2 regressions found
See build details here


Found 2 new test failures

Test Explanation Runs Upstream
o.a.c.index.sai.cql.VectorUpdateDeleteTest.testTTLOverwriteHasCorrectOnDiskRowCount[ca] (compression) NEW 🔴 0 / 0
o.a.c.utils.binlog.BinLogTest.testTruncationReleasesLogSpace (compression) NEW 🔴 0 / 0

No known test failures found

@adelapena adelapena merged commit 38bfb64 into cndb-main-release-202505 Oct 17, 2025
484 of 490 checks passed
@adelapena adelapena deleted the CNDB-15701-main-release-202505 branch October 17, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants