Skip to content

Conversation

@pkolaczk
Copy link

When row-aware and non-row-aware indexes are mixed, we now check
the clustering index filter for all the keys that have clustering
information, i.e. keys coming from the row-aware
indexes. Earlier that check was accidentally disabled
if at least one non-row-aware index was used by the query.
That could cause retrieving rows that do not match
the clustering condition of the query.

When row-aware and non-row-aware indexes are mixed, we now check
the clustering index filter for all the keys that have clustering
information, i.e. keys coming from the row-aware
indexes. Earlier that check was accidentally disabled
if at least one non-row-aware index was used by the query.
That could cause retrieving rows that do not match
the clustering condition of the query.
@github-actions
Copy link

github-actions bot commented Oct 20, 2025

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@sonarqubecloud
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2075 rejected by Butler


1 regressions found
See build details here


Found 1 new test failures

Test Explanation Runs Upstream
o.a.c.index.sai.cql.VectorSiftSmallTest.testCompaction (compression) NEW 🔴 0 / 0

No known test failures found

@pkolaczk
Copy link
Author

I ran this testt 5 times locally and it always passed. Probably a flaky test with a low-probability of failure:

[o.a.c.index.sai.cql.VectorSiftSmallTest.testCompaction (compression)](https://jenkins-stargazer.aws.dsinternal.org/job/ds-cassandra-pr-gate/job/PR-2075/1/testReport/org.apache.cassandra.index.sai.cql/VectorSiftSmallTest)
Post-compaction recall is 0.97

@pkolaczk pkolaczk merged commit 1e2868c into cndb-main-release-202505 Oct 20, 2025
485 of 490 checks passed
@pkolaczk pkolaczk deleted the c15683-may-release branch October 20, 2025 08:27
@pkolaczk
Copy link
Author

Making CNDB branch for it after merging to avoid additional run of CI, as we already know this is safe to merge (was merged to main).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants