CNDB-15745: Supports immutable components for SAI AA version #2079
+126
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
Updates the file formatting methods for SAI `Version.AA` to handle the generation used by immutable components, enabling the option to use immutable components with version AA. This also add a new `cassandra.sai.immutable_components.min_version` system property that allows to defines the minimum verison starting from which the existing `cassandra.sai.immutable_components` option will apply. As of this patch, this defaults to `ca`, because it is the behavior before this patch, but it can change to `aa` to allow using immutable components with `Version.AA`. Fixes #15745.
pcmanus
force-pushed
the
CNDB-15745-immutable-components-in-AA
branch
from
69965fa to
70fb738
Compare
|
✔️ Build ds-cassandra-pr-gate/PR-2079 approved by ButlerApproved by Butler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the file formatting methods for SAI
Version.AAto handle the generation used by immutable components, enabling the option to use immutable components with version AA.This also add a new
cassandra.sai.immutable_components.min_versionsystem property that allows to defines the minimum verison starting from which the existingcassandra.sai.immutable_componentsoption will apply. As of this patch, this defaults toca, because it is the behavior before this patch, but it can change toaato allow using immutable components withVersion.AA.Fixes https://github.com/riptano/cndb/issues/15745.