Skip to content

Conversation

@michaelsembwever
Copy link
Member

https://github.com/riptano/cndb/issues/15735

Port into main-5.0 commit 82064a0

CNDB-15735: CNDB-15619: Allow to customize SAI format to write and to consider as current() depending on a keyspace (#2041)

There is a new cassandra.sai.version.selector.class system property allowing to provide an implementation of the o.a.c.index.sai.disk.format.Version.Selector interface to specify that version of the SAI on-disk index format should be used for each keyspace.

… consider as current() depending on a keyspace (#2041)

There is a new cassandra.sai.version.selector.class system property allowing
to provide an implementation of the o.a.c.index.sai.disk.format.Version.Selector
interface to specify that version of the SAI on-disk index format should be
used for each keyspace.
@github-actions
Copy link

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@michaelsembwever
Copy link
Member Author

i still need to do a close review of the code here… (expecting a bomb of failures too…)

@sonarqubecloud
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2080 rejected by Butler


1 regressions found
See build details here


Found 1 new test failures

Test Explanation Runs Upstream
o.a.c.distributed.test.UnableToParseClientMessageTest.badHeader[version=5/v5] REGRESSION 🔴 0 / 12

Found 5 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants