Skip to content

Conversation

@pkolaczk
Copy link

@pkolaczk pkolaczk commented Nov 3, 2025

Cherry pick of #1860

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2025

@cassci-bot
Copy link

✔️ Build ds-cassandra-pr-gate/PR-2098 approved by Butler


Approved by Butler
See build details here

Copy link
Member

@michaeljmarshall michaeljmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because #1860 is already merged to main. My primary concern here is that the original commit on main doesn't actually describe when it is safe to use this setting and since this is a cherry picked commit, this doesn't either.

@pkolaczk
Copy link
Author

pkolaczk commented Nov 3, 2025

I am retracting this after reading the cndb-side comments, especially this one: https://github.com/riptano/cndb/pull/14772#issuecomment-3357605350

@pkolaczk pkolaczk closed this Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants