-
Notifications
You must be signed in to change notification settings - Fork 32
feat: add health check in temporal service and retry with exponential backoff for Temporal client #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ove health checks
| // Construct a query for workflows related to this project and job | ||
| query := fmt.Sprintf("WorkflowId between 'sync-%s-%d' and 'sync-%s-%d-~'", projectIDStr, job.ID, projectIDStr, job.ID) | ||
| // List workflows using the direct query | ||
| if c.tempClient == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In destination.go and source.go we are using
if c.tempClient != nil {
}Here we are checking
if c.tempClient == nil {
utils.ErrorResponse(&c.Controller, http.StatusInternalServerError, "Temporal client is not initialized")
return
}Can we make it consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to avoid extra lines of code, at some places we not using response from function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if c.tempClient == nil {
utils.ErrorResponse(&c.Controller, http.StatusInternalServerError, "Temporal client is not initialized")
return
}I mean we are throwing this error only in job, and not in source and destination. Just to make it consistent.
… into feat/temporal-retry-health
|
Closing as already implemented backoff in refactoring. |

…ove health checks
Description
Fixes # (issue)
Type of change
How Has This Been Tested?
Screenshots or Recordings
Related PR's (If Any):