refactor(postgres): pass context to database queries in chunk processing functions #361
Conversation
abhinav-1305
changed the title
|
please review - @hash-data |
There was a problem hiding this comment.
Use QueryContext function in ChunkIterator function in postgres backfill.go.
@abhinav-1305
| err := p.client.QueryRowContext(ctx, nextChunkEnd).Scan(&chunkEnd) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to query[%s] next chunk end: %s", nextChunkEnd, err) | ||
| } |
There was a problem hiding this comment.
Check for context in MySQL and MongoDB drivers as well, where ever there is a direct call for driver instance or server.
@abhinav-1305
There was a problem hiding this comment.
Can this be addressed in other pr?
There was a problem hiding this comment.
Can this be addressed in other pr?
Do changes in the CDC for postgres. For mongoDB you can raise another PR if there is any context changes, for the MySQL one please do changes here itself if possible. Pease check for CDC for other drivers as well.
| }) | ||
| } | ||
|
|
||
| func (p *Postgres) GetOrSplitChunks(_ context.Context, pool *destination.WriterPool, stream types.StreamInterface) (*types.Set[types.Chunk], error) { |
There was a problem hiding this comment.
in doesReplicationSlotExists as well use QueryRowContext
|
@abhinav-1305 , any update from your side. also change the merge branch to staging |
3 participants
Description
Fixes #319
Type of change
How Has This Been Tested?
Screenshots or Recordings
Related PR's (If Any):