feat: clear destination in iceberg

destination/iceberg/iceberg.go

@@ -267,9 +267,6 @@ func (i *Iceberg) Check(ctx context.Context) error {
 
 	// to close client properly
 	i.server = server
-	defer func() {
-		i.Close(ctx)
-	}()
 
 	ctx, cancel := context.WithTimeout(ctx, 30*time.Second)
 	defer cancel()
@@ -570,17 +567,46 @@ func (i *Iceberg) parsePartitionRegex(pattern string) error {
 	return nil
 }
 
-func (i *Iceberg) DropStreams(_ context.Context, _ []string) error {
-	logger.Info("iceberg destination not support clear destination, skipping clear operation")
+// drop streams required for clear destination
+func (i *Iceberg) DropStreams(ctx context.Context, dropStreams []types.StreamInterface) error {
+	if len(dropStreams) == 0 {
+		logger.Info("No streams selected for clearing Iceberg destination, skipping operation")
+		return nil
+	}
+
+	// to close client properly
+	defer func() {
+		i.Close(ctx)
+	}()
+
+	logger.Infof("Starting Clear Iceberg destination for %d selected streams", len(dropStreams))
+
+	// process each stream
+	for _, stream := range dropStreams {
+		destDB := stream.GetDestinationDatabase(&i.config.IcebergDatabase)
+		destTable := stream.GetDestinationTable()
+		dropTable := fmt.Sprintf("%s.%s", destDB, destTable)
 
-	// logger.Infof("Clearing Iceberg destination for %d selected streams: %v", len(selectedStreams), selectedStreams)
+		logger.Infof("Dropping Iceberg table: %s", dropTable)
 
-	// TODO: Implement Iceberg table clearing logic
-	// 1. Connect to the Iceberg catalog
-	// 2. Use Iceberg's delete API or drop/recreate the table
-	// 3. Handle any Iceberg-specific cleanup
+		request := proto.IcebergPayload{
+			Type: proto.IcebergPayload_DROP_TABLE,
+			Metadata: &proto.IcebergPayload_Metadata{
+				DestTableName: dropTable,
+				ThreadId:      i.server.serverID,
+			},
+		}
+		_, err := i.server.sendClientRequest(ctx, &request)
+		if err != nil {
+			if strings.Contains(err.Error(), "not found") {
+				logger.Infof("Table %s does not exist, skipping drop", dropTable)
+				continue
+			}
+			return fmt.Errorf("failed to drop table %s: %s", dropTable, err)
+		}
+	}
 
-	// logger.Info("Successfully cleared Iceberg destination for selected streams")
+	logger.Info("Successfully cleared Iceberg destination for selected streams")
 	return nil
 }
 

destination/iceberg/olake-iceberg-java-writer/src/main/java/io/debezium/server/iceberg/IcebergUtil.java

@@ -265,4 +265,20 @@ public static int partitionId() {
     return Integer.parseInt(dtFormater.format(Instant.now()));
   }
 
+  public static boolean dropIcebergTable(String namespace, String tableName, Catalog icebergCatalog) {
+    try{
+      TableIdentifier tableID = TableIdentifier.of(namespace, tableName);
+      // Check if table exists
+      if (!icebergCatalog.tableExists(tableID)) {
+        LOGGER.warn("Table not found: {}", tableID.toString());
+        return false;
+      }
+      icebergCatalog.dropTable(tableID, true);
+      return true;
+    } catch(Exception e){
+      LOGGER.error("Failed to drop table {}.{}: {}", namespace, tableName, e.getMessage());
+      throw new RuntimeException("Failed to drop table: " + namespace + "." + tableName, e);
+    }
+  }
+
 }

destination/iceberg/olake-iceberg-java-writer/src/main/java/io/debezium/server/iceberg/rpc/OlakeRowsIngester.java

@@ -111,10 +111,24 @@ public void sendRecords(IcebergPayload request, StreamObserver<RecordIngest.Reco
                     break;
 
                 case DROP_TABLE:
-                    LOGGER.warn("{} Table {} not dropped, drop table not implemented", requestId, destTableName);
-                    sendResponse(responseObserver, "Drop table not implemented");
+                    String dropTable = metadata.getDestTableName();
+                    String[] parts = dropTable.split("\\.", 2);
+                    if (parts.length != 2) {
+                        throw new IllegalArgumentException("Invalid destination table name: " + dropTable);
+                    }
+                    String namespace = parts[0], tableName = parts[1];
+
+                    LOGGER.warn("{} Dropping table {}.{}", requestId, namespace, tableName);
+
+                    boolean dropped = IcebergUtil.dropIcebergTable(namespace, tableName, icebergCatalog);
+                    if (dropped) {
+                        sendResponse(responseObserver, "Successfully dropped table " + tableName);
+                        LOGGER.info("{} Table {} dropped", requestId, tableName);
+                    } else {
+                        sendResponse(responseObserver, "Table " + tableName + " does not exist");
+                        LOGGER.warn("{} Table {} not dropped, table does not exist", requestId, tableName);
+                    }
                     break;
-
                 default:
                     throw new IllegalArgumentException("Unknown payload type: " + request.getType());
             }

destination/interface.go

@@ -32,6 +32,6 @@ type Writer interface {
 	// Need to pass olakeTimestamp as end argument to get the correct partition path based on record ingestion time.
 	EvolveSchema(ctx context.Context, globalSchema, recordsSchema any) (any, error)
 	// DropStreams is used to clear the destination before re-writing the stream
-	DropStreams(ctx context.Context, selectedStream []string) error
+	DropStreams(ctx context.Context, dropStreams []types.StreamInterface) error
 	Close(ctx context.Context) error
 }

destination/parquet/parquet.go

@@ -421,7 +421,7 @@ func (p *Parquet) getPartitionedFilePath(values map[string]any, olakeTimestamp t
 	return filepath.Join(p.basePath, strings.TrimSuffix(result, "/"))
 }
 
-func (p *Parquet) DropStreams(ctx context.Context, selectedStreams []string) error {
+func (p *Parquet) DropStreams(ctx context.Context, selectedStreams []types.StreamInterface) error {
 	if len(selectedStreams) == 0 {
 		logger.Infof("Thread[%s]: no streams selected for clearing, skipping clear operation", p.options.ThreadID)
 		return nil
@@ -443,16 +443,11 @@ func (p *Parquet) DropStreams(ctx context.Context, selectedStreams []string) err
 	return nil
 }
 
-func (p *Parquet) clearLocalFiles(selectedStreams []string) error {
-	for _, streamID := range selectedStreams {
-		parts := strings.SplitN(streamID, ".", 2)
-		if len(parts) != 2 {
-			logger.Warnf("Thread[%s]: invalid stream ID format: %s, skipping", p.options.ThreadID, streamID)
-			continue
-		}
-
-		namespace, streamName := parts[0], parts[1]
-		streamPath := filepath.Join(p.config.Path, namespace, streamName)
+func (p *Parquet) clearLocalFiles(selectedStreams []types.StreamInterface) error {
+	for _, stream := range selectedStreams {
+		namespace := stream.GetDestinationDatabase(nil)
+		tableName := stream.GetDestinationTable()
+		streamPath := filepath.Join(p.config.Path, namespace, tableName)
 
 		logger.Infof("Thread[%s]: clearing local path: %s", p.options.ThreadID, streamPath)
 
@@ -471,7 +466,7 @@ func (p *Parquet) clearLocalFiles(selectedStreams []string) error {
 	return nil
 }
 
-func (p *Parquet) clearS3Files(ctx context.Context, selectedStreams []string) error {
+func (p *Parquet) clearS3Files(ctx context.Context, selectedStreams []types.StreamInterface) error {
 	deleteS3PrefixStandard := func(filtPath string) error {
 		iter := s3manager.NewDeleteListIterator(p.s3Client, &s3.ListObjectsInput{
 			Bucket: aws.String(p.config.Bucket),
@@ -484,15 +479,11 @@ func (p *Parquet) clearS3Files(ctx context.Context, selectedStreams []string) er
 		return nil
 	}
 
-	for _, streamID := range selectedStreams {
-		parts := strings.SplitN(streamID, ".", 2)
-		if len(parts) != 2 {
-			logger.Warnf("Thread[%s]: invalid stream ID format: %s, skipping", p.options.ThreadID, streamID)
-			continue
-		}
+	for _, stream := range selectedStreams {
+		namespace := stream.GetDestinationDatabase(nil)
+		tableName := stream.GetDestinationTable()
+		s3TablePath := filepath.Join(p.config.Prefix, namespace, tableName, "/")
 
-		namespace, streamName := parts[0], parts[1]
-		s3TablePath := filepath.Join(p.config.Prefix, namespace, streamName, "/")
 		logger.Debugf("Thread[%s]: clearing S3 prefix: s3://%s/%s", p.options.ThreadID, p.config.Bucket, s3TablePath)
 		if err := deleteS3PrefixStandard(s3TablePath); err != nil {
 			return fmt.Errorf("failed to clear S3 prefix %s: %s", s3TablePath, err)

destination/writers.go

@@ -83,7 +83,7 @@ func WithThreadID(threadID string) ThreadOptions {
 	}
 }
 
-func NewWriterPool(ctx context.Context, config *types.WriterConfig, syncStreams, dropStreams []string) (*WriterPool, error) {
+func NewWriterPool(ctx context.Context, config *types.WriterConfig, syncStreams []string, dropStreams []types.StreamInterface) (*WriterPool, error) {
 	newfunc, found := RegisteredWriters[config.Type]
 	if !found {
 		return nil, fmt.Errorf("invalid destination type has been passed [%s]", config.Type)

protocol/sync.go

@@ -88,7 +88,7 @@ var syncCmd = &cobra.Command{
 		incrementalStreams := []types.StreamInterface{}
 		standardModeStreams := []types.StreamInterface{}
 		newStreamsState := []*types.StreamState{}
-		fullLoadStreams := []string{}
+		dropStreams := []types.StreamInterface{}
 
 		var stateStreamMap = make(map[string]*types.StreamState)
 		for _, stream := range state.Streams {
@@ -131,7 +131,6 @@ var syncCmd = &cobra.Command{
 					newStreamsState = append(newStreamsState, streamState)
 				}
 			default:
-				fullLoadStreams = append(fullLoadStreams, elem.ID())
 				standardModeStreams = append(standardModeStreams, elem)
 			}
 
@@ -144,8 +143,12 @@ var syncCmd = &cobra.Command{
 
 		logger.Infof("Valid selected streams are %s", strings.Join(selectedStreams, ", "))
 
-		fullLoadStreams = utils.Ternary(clearDestinationFlag, selectedStreams, fullLoadStreams).([]string)
-		pool, err := destination.NewWriterPool(cmd.Context(), destinationConfig, selectedStreams, fullLoadStreams)
+		dropStreams = append(dropStreams, standardModeStreams...)
+		if clearDestinationFlag {
+			dropStreams = append(dropStreams, cdcStreams...)
+			dropStreams = append(dropStreams, incrementalStreams...)
+		}
+		pool, err := destination.NewWriterPool(cmd.Context(), destinationConfig, selectedStreams, dropStreams)
 		if err != nil {
 			return err
 		}