Skip to content

fix: Azure ADLS Lakekeeper Rest Catalog Issue #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 17, 2025
Merged

fix: Azure ADLS Lakekeeper Rest Catalog Issue #591

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ad439f0
fix: iceberg api automatically handles s3 or gcs or adls config
badalprasadsingh Oct 15, 2025
f0bc3f3
fix: minor
badalprasadsingh Oct 15, 2025
751b587
fix: minor
badalprasadsingh Oct 15, 2025
adcf2be
fix: minor
badalprasadsingh Oct 16, 2025
623b887
fix: minor
badalprasadsingh Oct 16, 2025
8543723
fix: minor
badalprasadsingh Oct 16, 2025
47e1146
fix: gcs
badalprasadsingh Oct 16, 2025
a4c4ce8
fix: minor
badalprasadsingh Oct 16, 2025
ddf01df
fix: minor
badalprasadsingh Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions destination/iceberg/java_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,16 +114,11 @@ func getServerConfigJSON(config *Config, partitionInfo []PartitionInfo, port int
logger.Warnf("No region explicitly provided for Glue catalog, the Java process will attempt to use region from AWS environment")
}

// Configure custom endpoint for S3-compatible services (like MinIO)
if config.S3Endpoint != "" {
serverConfig["s3.endpoint"] = config.S3Endpoint
serverConfig["io-impl"] = "org.apache.iceberg.io.ResolvingFileIO"
// Set SSL/TLS configuration
serverConfig["s3.ssl-enabled"] = utils.Ternary(config.S3UseSSL, "true", "false").(string)
}

// Configure S3 or GCP file IO
serverConfig["io-impl"] = utils.Ternary(strings.HasPrefix(config.IcebergS3Path, "gs://"), "org.apache.iceberg.gcp.gcs.GCSFileIO", "org.apache.iceberg.aws.s3.S3FileIO")
serverConfig["io-impl"] = "org.apache.iceberg.io.ResolvingFileIO"
serverConfig["s3.ssl-enabled"] = utils.Ternary(config.S3UseSSL, "true", "false").(string)

// Marshal the config to JSON
return json.Marshal(serverConfig)
Expand Down
Loading