[CB] SQL Query generation: front-end part #4117

sergeyteleshev · 2026-02-05T12:45:56Z

closes https://github.com/dbeaver/pro/issues/8048

…/pro#8047-create-sql-dialog-for-result-set-frontend

Copilot

Pull request overview

Adds the front-end integration for SQL query generation, wiring a new SQL generation dialog into existing UI flows (SQL generators menu + data grid context menu) and introducing supporting SDK/query and utility plumbing.

Changes:

Add result-set SQL generation support via a new GraphQL query and a SqlGeneratorsResource.generateResultSetSql method.
Introduce a “Generate SQL” data grid context menu (INSERT/UPDATE/DELETE/SELECT/SELECT IN) that opens the shared generated-SQL dialog.
Add a core-utils helper (executeAsyncSilently) with tests and adopt it in SQL generation entry points.

Reviewed changes

Copilot reviewed 30 out of 31 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
webapp/yarn.lock	Adds workspace dependencies for the new plugin usage and core-utils reference.
webapp/packages/plugin-sql-generator/tsconfig.json	Adds `core-utils` project reference for new imports.
webapp/packages/plugin-sql-generator/src/index.ts	Exports `GeneratedSqlDialog` for reuse by other plugins.
webapp/packages/plugin-sql-generator/src/SqlGenerators/SqlGeneratorsResource.ts	Adds `generateResultSetSql` calling the new SDK query.
webapp/packages/plugin-sql-generator/src/SqlGenerators/SqlGeneratorsBootstrap.ts	Switches to prefetching SQL + passing query/exception into the dialog.
webapp/packages/plugin-sql-generator/src/SqlGenerators/GeneratedSqlDialog.tsx	Refactors dialog to accept `{ query, exception, nodeId }` payload and removes internal loading/fetch logic.
webapp/packages/plugin-sql-generator/package.json	Adds `@cloudbeaver/core-utils` dependency.
webapp/packages/plugin-data-viewer/src/ContainerDataSource.ts	Updates copyright year.
webapp/packages/plugin-data-spreadsheet-new/tsconfig.json	Adds project reference to `plugin-sql-generator`.
webapp/packages/plugin-data-spreadsheet-new/src/module.ts	Registers `DataGridContextMenuGenerateSqlService`.
webapp/packages/plugin-data-spreadsheet-new/src/locales/zh.ts	Adds “Generate SQL” menu/dialog/error translations.
webapp/packages/plugin-data-spreadsheet-new/src/locales/vi.ts	Adds “Generate SQL” menu/dialog/error translations.
webapp/packages/plugin-data-spreadsheet-new/src/locales/ru.ts	Adds “Generate SQL” menu/dialog/error translations.
webapp/packages/plugin-data-spreadsheet-new/src/locales/it.ts	Adds “Generate SQL” menu/dialog/error translations.
webapp/packages/plugin-data-spreadsheet-new/src/locales/fr.ts	Adds “Generate SQL” menu/dialog/error translations.
webapp/packages/plugin-data-spreadsheet-new/src/locales/en.ts	Adds “Generate SQL” menu/dialog/error translations.
webapp/packages/plugin-data-spreadsheet-new/src/locales/de.ts	Adds “Generate SQL” menu/dialog/error translations.
webapp/packages/plugin-data-spreadsheet-new/src/SpreadsheetBootstrap.ts	Wires `DataGridContextMenuGenerateSqlService` into bootstrap registration.
webapp/packages/plugin-data-spreadsheet-new/src/DataGrid/DataGridContextMenu/GenerateSQL/MENU_DATA_GRID_GENERATE_SQL.ts	Introduces the top-level “Generate SQL” context menu.
webapp/packages/plugin-data-spreadsheet-new/src/DataGrid/DataGridContextMenu/DataGridContextMenuGenerateSqlService.ts	Implements menu/actions handler and invokes result-set SQL generation + dialog opening.
webapp/packages/plugin-data-spreadsheet-new/src/DataGrid/Actions/GenerateSQL/ACTION_DATA_GRID_GENERATE_SQL_UPDATE.ts	Adds UPDATE action definition.
webapp/packages/plugin-data-spreadsheet-new/src/DataGrid/Actions/GenerateSQL/ACTION_DATA_GRID_GENERATE_SQL_SELECT_MANY.ts	Adds SELECT (IN) action definition.
webapp/packages/plugin-data-spreadsheet-new/src/DataGrid/Actions/GenerateSQL/ACTION_DATA_GRID_GENERATE_SQL_SELECT.ts	Adds SELECT action definition.
webapp/packages/plugin-data-spreadsheet-new/src/DataGrid/Actions/GenerateSQL/ACTION_DATA_GRID_GENERATE_SQL_INSERT.ts	Adds INSERT action definition.
webapp/packages/plugin-data-spreadsheet-new/src/DataGrid/Actions/GenerateSQL/ACTION_DATA_GRID_GENERATE_SQL_DELETE.ts	Adds DELETE action definition.
webapp/packages/plugin-data-spreadsheet-new/package.json	Adds dependency on `@cloudbeaver/plugin-sql-generator`.
webapp/packages/plugin-data-import/src/DataImportBootstrap.ts	Updates copyright year.
webapp/packages/core-utils/src/index.ts	Exports the new `executeAsyncSilently` helper.
webapp/packages/core-utils/src/executeAsyncSilently.ts	Adds `executeAsyncSilently` helper for capturing `{ result, error }`.
webapp/packages/core-utils/src/executeAsyncSilently.test.ts	Adds Vitest coverage for the new helper.
webapp/packages/core-sdk/src/queries/sqlGenerateResultSetQuery.gql	Adds GraphQL query for generating SQL from a result set selection.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

webapp/packages/core-utils/src/executeAsyncSilently.ts

webapp/packages/core-utils/src/executeAsyncSilently.test.ts

...ta-spreadsheet-new/src/DataGrid/DataGridContextMenu/DataGridContextMenuGenerateSqlService.ts

webapp/packages/plugin-sql-generator/src/SqlGenerators/GeneratedSqlDialog.tsx

SychevAndrey · 2026-02-09T09:42:53Z

...ta-spreadsheet-new/src/DataGrid/DataGridContextMenu/DataGridContextMenuGenerateSqlService.ts

+
+        return isResultSetDataModel(model) && !model.source.isReadonly(resultIndex);
+      },
+      getItems: (context, items) => [...items, MENU_DATA_GRID_GENERATE_SQL],


why don't we let to generate selects for readony?

Cause we decided we don't want this feature for the Grouping panel and Session Manager
We want this feature for: data editor, SQL result sets, and datasets

this is hard to understand from code, that model.source.isReadonly(resultIndex) is about excluding Grouping panel and Session Manager

We can use helpers such as isDatabaseSessionManagerDataSource that is already exist to exclude specific data sources

this is what we already do:

cloudbeaver/webapp/packages/plugin-data-spreadsheet-new/src/DataGrid/DataGridContextMenu/DataGridContextMenuCellEditingService.ts

Line 67 in b180f97

return isResultSetDataSource(model.source) && !model.isDisabled(resultIndex) && !model.isReadonly(resultIndex);

...ta-spreadsheet-new/src/DataGrid/DataGridContextMenu/DataGridContextMenuGenerateSqlService.ts

…/pro#8047-create-sql-dialog-for-result-set-frontend

...ta-spreadsheet-new/src/DataGrid/DataGridContextMenu/DataGridContextMenuGenerateSqlService.ts

webapp/packages/core-utils/src/executeAsyncSilently.ts

...ata-spreadsheet-new/src/DataGrid/Actions/GenerateSQL/ACTION_DATA_GRID_GENERATE_SQL_DELETE.ts

Wroud · 2026-02-09T13:28:35Z

...ta-spreadsheet-new/src/DataGrid/DataGridContextMenu/DataGridContextMenuGenerateSqlService.ts

+
+        return isResultSetDataModel(model) && !model.source.isReadonly(resultIndex);
+      },
+      getItems: (context, items) => [...items, MENU_DATA_GRID_GENERATE_SQL],


this is hard to understand from code, that model.source.isReadonly(resultIndex) is about excluding Grouping panel and Session Manager

...ta-spreadsheet-new/src/DataGrid/DataGridContextMenu/DataGridContextMenuGenerateSqlService.ts

Wroud · 2026-02-09T13:30:32Z

...ta-spreadsheet-new/src/DataGrid/DataGridContextMenu/DataGridContextMenuGenerateSqlService.ts

+      isActionApplicable: (context, action) =>
+        [
+          ACTION_DATA_GRID_GENERATE_SQL_INSERT,
+          ACTION_DATA_GRID_GENERATE_SQL_UPDATE,
+          ACTION_DATA_GRID_GENERATE_SQL_DELETE,
+          ACTION_DATA_GRID_GENERATE_SQL_SELECT,
+          ACTION_DATA_GRID_GENERATE_SQL_SELECT_MANY,
+        ].includes(action),


just specify:

actions: [ ACTION_DATA_GRID_GENERATE_SQL_INSERT, ACTION_DATA_GRID_GENERATE_SQL_UPDATE, ACTION_DATA_GRID_GENERATE_SQL_DELETE, ACTION_DATA_GRID_GENERATE_SQL_SELECT, ACTION_DATA_GRID_GENERATE_SQL_SELECT_MANY, ]

the main purpose of the IAction is to provide additional behaviour such as shortcuts or reusability in different contexts, IAction is some of kind standarterized action in the application that can be used in different contexts (menus, menu bars), you don't need to create action for every item in the menu, sometimes it's more convenient to use MenuBaseItem

webapp/packages/core-utils/src/executeAsyncSilently.ts

...ta-spreadsheet-new/src/DataGrid/DataGridContextMenu/DataGridContextMenuGenerateSqlService.ts

Copilot

Pull request overview

Copilot reviewed 40 out of 41 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...ta-spreadsheet-new/src/DataGrid/DataGridContextMenu/DataGridContextMenuGenerateSqlService.ts

webapp/packages/core-localization/src/locales/en.ts

…/pro#8047-create-sql-dialog-for-result-set-frontend

dbeaver/pro#8047 adds ui for the sql generation in result set

90f2f1d

sergeyteleshev self-assigned this Feb 5, 2026

sergeyteleshev requested review from SychevAndrey, Wroud and devnaumov February 5, 2026 12:45

sergeyteleshev added 7 commits February 5, 2026 15:11

dbeaver/pro#8047 reuses generated sql dialog

344c54a

adds translation + unit tests

9318d38

Merge branch 'dbeaver/pro#8047-resultset-sql-generation' into dbeaver…

d299a44

…/pro#8047-create-sql-dialog-for-result-set-frontend

refactors generate sql

5cdcebd

adds feature for data editor

745da0a

disables feature for long text and blobs

1d70e78

disables feature for readonly tables

c732628

sergeyteleshev marked this pull request as ready for review February 6, 2026 12:16

SychevAndrey requested a review from Copilot February 9, 2026 09:19

Copilot started reviewing on behalf of SychevAndrey February 9, 2026 09:20 View session

Copilot AI reviewed Feb 9, 2026

View reviewed changes

SychevAndrey requested changes Feb 9, 2026

View reviewed changes

Merge branch 'dbeaver/pro#8047-resultset-sql-generation' into dbeaver…

04c486d

…/pro#8047-create-sql-dialog-for-result-set-frontend

SychevAndrey reviewed Feb 9, 2026

View reviewed changes

...ta-spreadsheet-new/src/DataGrid/DataGridContextMenu/DataGridContextMenuGenerateSqlService.ts Outdated Show resolved Hide resolved

devnaumov requested changes Feb 9, 2026

View reviewed changes

webapp/packages/core-utils/src/executeAsyncSilently.ts Outdated Show resolved Hide resolved

...ata-spreadsheet-new/src/DataGrid/Actions/GenerateSQL/ACTION_DATA_GRID_GENERATE_SQL_DELETE.ts Outdated Show resolved Hide resolved

sergeyteleshev added 3 commits February 9, 2026 14:31

pr fixes

cab224e

build fix

28a8877

build fix 2

b180f97

Wroud reviewed Feb 9, 2026

View reviewed changes

pr fixes

f86c48a

sergeyteleshev requested review from SychevAndrey, Wroud, Copilot and devnaumov February 9, 2026 15:27

Copilot started reviewing on behalf of sergeyteleshev February 9, 2026 15:28 View session

Copilot AI reviewed Feb 9, 2026

View reviewed changes

...ta-spreadsheet-new/src/DataGrid/DataGridContextMenu/DataGridContextMenuGenerateSqlService.ts Show resolved Hide resolved

webapp/packages/core-localization/src/locales/en.ts Show resolved Hide resolved

sergeyteleshev added 2 commits February 10, 2026 09:37

adds comments for refactor

93d9245

Merge branch 'dbeaver/pro#8047-resultset-sql-generation' into dbeaver…

82ecf21

…/pro#8047-create-sql-dialog-for-result-set-frontend

Wroud approved these changes Feb 10, 2026

View reviewed changes

SychevAndrey approved these changes Feb 10, 2026

View reviewed changes

Merge branch 'dbeaver/pro#8047-resultset-sql-generation' into dbeaver…

27bd33e

…/pro#8047-create-sql-dialog-for-result-set-frontend

[CB] SQL Query generation: front-end part #4117

Are you sure you want to change the base?

[CB] SQL Query generation: front-end part #4117

Conversation

sergeyteleshev commented Feb 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SychevAndrey Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

sergeyteleshev Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Wroud Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

devnaumov Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sergeyteleshev Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Wroud Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Wroud Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Wroud Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

devnaumov Feb 9, 2026 •

edited

Loading