Skip to content

Updated impala-configs.md with a missed configurable parameter #7907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 28, 2025
Merged

Updated impala-configs.md with a missed configurable parameter #7907

merged 8 commits into from
Oct 28, 2025

Conversation

@niranjancdw
Copy link
Contributor

@niranjancdw niranjancdw commented Sep 15, 2025 •
edited
Loading

What are you changing in this pull request and why?

As part of acquiring Trusted Adapters status to dbt-impala adapter

  • updated the documentation to be correct
  • removed the references of Apache

Checklist

@vercel
Copy link

vercel bot commented Sep 15, 2025

@niranjancdw is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the content Improvements or additions to content label Sep 15, 2025
niteshy
niteshy approved these changes Sep 17, 2025
View reviewed changes
Copy link

@niteshy niteshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niranjancdw niranjancdw requested a review from niteshy September 29, 2025 11:27
@niranjancdw niranjancdw marked this pull request as ready for review September 29, 2025 11:28
@niranjancdw niranjancdw requested a review from a team as a code owner September 29, 2025 11:28
@niranjancdw
Copy link
Contributor Author

niranjancdw commented Oct 3, 2025

HI @matthewshaver
When you get a chance please take a look at this PR, this is similar to the one #7906 you approved and merged.

@niranjancdw
Copy link
Contributor Author

niranjancdw commented Oct 8, 2025

Hi @matthewshaver @amychen1776

Please take a look at this when you get a chance.

@amychen1776 amychen1776 enabled auto-merge October 8, 2025 12:48
@niranjancdw
Copy link
Contributor Author

niranjancdw commented Oct 27, 2025

Hello @amychen1776 @matthewshaver

Any update on this PR?

matthewshaver
matthewshaver approved these changes Oct 28, 2025
View reviewed changes
Copy link
Contributor

@matthewshaver matthewshaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @niranjancdw

@vercel
Copy link

vercel bot commented Oct 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
docs-getdbt-com Ready Ready Preview Oct 28, 2025 1:32pm

@amychen1776 amychen1776 merged commit ee4d16f into dbt-labs:current Oct 28, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewshaver matthewshaver matthewshaver approved these changes

@niteshy niteshy Awaiting requested review from niteshy

+1 more reviewer

@amychen1776 amychen1776 amychen1776 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

content Improvements or additions to content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@niranjancdw @niteshy @amychen1776 @matthewshaver