task: adds drush install/remove bypass for drupal main branch #61#62
Open
mradcliffe wants to merge 1 commit intoddev:mainfrom
Open
task: adds drush install/remove bypass for drupal main branch #61#62mradcliffe wants to merge 1 commit intoddev:mainfrom
mradcliffe wants to merge 1 commit intoddev:mainfrom
Conversation
Authored by: mradcliffe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
drush/drush and drupal/core-recommended conflict due to Symfony 8.
How This PR Solves The Issue
Prevents drush from being installed or removes drush when DRUPAL_BRANCH is main so that composer install will work.
This means that any further drush commands will fail, and Drupal will need to be installed via the user interface.
Adds a todo to follow-up and either revert this code or change to using a future core CLI command. Hopefully that is done in the next 3-6 months.
Manual Testing Instructions
I am not sure how to manually test since I am new to coder-ddev.
Automated Testing Overview
Hopefully the "::main:drupal12" test will pass.
Related Issue Link(s)
#61
Release/Deployment Notes