-
Notifications
You must be signed in to change notification settings - Fork 575
fix(tf): make dipole, polar, and dos models consistent with dpmodel #4962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
35b9aba
Initial plan
Copilot 06a69f5
feat(tf): complete out_bias and out_std implementation with integrati…
Copilot 93cd873
feat(tf): implement decoupled out_bias and out_std in TensorFlow back…
Copilot 0953edf
refactor(tf): consolidate out_bias/out_std application into shared me…
Copilot 4a82cfe
refactor(tf): address review feedback - clean up hasattr checks and b…
Copilot d8bbd00
refactor(tf): use _get_dim_out() method consistently to eliminate dup…
Copilot 8014159
refactor(tf): consolidate duplicate output dimension logic and remove…
Copilot 519b7bb
chore: remove test system files that should not be committed
Copilot 6d67e25
enable consistent tests
njzjz 11575e8
Apply suggestions from code review
njzjz 10b012e
Potential fix for code scanning alert no. 9973: Unused local variable
njzjz a061950
Remove unused variable 'nframes' from TensorModel and TestOutBiasStd
njzjz ab4f31b
Addressing PR comments
Copilot fc56cab
refactor(tf): remove get/set methods for out_bias and out_std and upd…
Copilot 012e556
fix tests
njzjz 9a04df9
fix(tf): add missing _apply_out_bias_std call in TensorModel build me…
Copilot ba1204e
Revert "fix(tf): add missing _apply_out_bias_std call in TensorModel …
njzjz 552acd2
fix dos
njzjz 000a453
fix nall/nloc issues
njzjz aa90139
feat(tf): add r_differentiable and c_differentiable to polar fitting …
Copilot a1cd310
fix(tf): remove r_differentiable and c_differentiable from polar fitt…
Copilot 0281aa8
chore: remove system directory test files and add to .gitignore
Copilot 059fd74
feat(tf): add debug logging for out_bias/out_std fallback behavior
Copilot 600caab
style: update logging to follow codebase pattern and remove unnecessa…
Copilot 35b89cf
refactor(tf): remove unused _get_selected_atype method from TensorModel
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,3 +68,6 @@ lcurve.out | |
out.json | ||
input_v2_compat.json | ||
frozen_model.* | ||
|
||
# Test system directories | ||
system/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.