Fix code scanning alert no. 4: Arbitrary file write during tarfile extraction

[njzjz]

Fixes https://github.com/deepmodeling/dpdispatcher/security/code-scanning/4

To fix the problem, we need to ensure that the paths of the files within the tar archive do not contain any directory traversal elements (..). This can be done by checking each file path before extraction and raising an error if any path is found to be unsafe.

Steps to fix:

1. Check Paths: Before extracting each file, check if the path is absolute or contains ... If it does, raise an error.
2. Modify Extraction Logic: Update the extraction logic to include this validation step.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Summary by CodeRabbit

• New Features

  • Enhanced security with validation for illegal tar archive entries in file operations.
  • Improved command execution reliability with a retry mechanism for SSH sessions.
  • Conditional utilization of rsync for file transfers based on availability and session validity.

• Bug Fixes

  • Updated error handling for SSH commands and file transfers to improve robustness.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request introduces modifications to the SSHContext and SSHSession classes within the dpdispatcher/contexts/ssh_context.py file. Key changes include the addition of validation in the _get_files method to prevent illegal tar archive entries, an updated exec_command method with a retry mechanism for command execution, and enhancements to the put and get methods to conditionally utilize rsync based on availability and password presence. The rsync_available property has also been updated to reflect these changes.

Changes

File	Change Summary
dpdispatcher/contexts/ssh_context.py	- Updated _get_files method to include validation for illegal tar archive entries.
	- Modified exec_command method to add a retry mechanism for command execution.
	- Enhanced put and get methods to conditionally use rsync based on availability and password.
	- Updated rsync_available property to improve checks for rsync command and SSH session validity.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.