feat: complete partial note from private

[ilpepepig]

🤖 Linear

Closes AZT-330

Description

---

Note

Transfer to commitment now completes the partial note directly in private, removing the public helper; test updated for new failure message.

• Token Contract:
  • Private transfer to commitment: Replace enqueued increase_commitment_balance_internal with PartialUintNote::from_field(commitment).complete_from_private(&mut context, completer, amount) to complete in private.
  • Remove public/internal increase_commitment_balance_internal function.
• Tests:
  • Update failing case expectation in src/token_contract/src/test/transfer_private_to_commitment.nr to "Nullifier witness not found for nullifier".

^{Written by Cursor Bugbot for commit 6b56872. This will update automatically on new commits. Configure here.}

[linear]

AZT-330 Complete partial notes from private

The base branch was changed.

[github-actions]

Benchmark Comparison

Contract: nft

	Function	Gates			DA Gas			L2 Gas
Status		Base	PR	Diff	Base	PR	Diff	Base	PR	Diff
⚪	burn_private	414,611	414,611		2,816	2,816		43,789	43,789
⚪	burn_public	309,109	309,109		3,380	3,380		50,475	50,475
⚪	mint_to_private	431,929	431,929		13,517	13,517		43,565	43,565
⚪	mint_to_public	309,109	309,109		3,380	3,380		56,220	56,220
⚪	transfer_private_to_private	398,132	398,132		12,954	12,954		5,296	5,296
⚪	transfer_private_to_public	414,614	414,614		2,816	2,816		37,605	37,605
⚪	transfer_public_to_private	428,564	428,564		13,517	13,517		43,964	43,964
⚪	transfer_public_to_public	309,109	309,109		2,253	2,253		43,145	43,145

Contract: token

	Function	Gates			DA Gas			L2 Gas
Status		Base	PR	Diff	Base	PR	Diff	Base	PR	Diff
⚪	burn_private	438,977	438,977		14,081	14,081		34,956	34,887	-69 (-0.2%)
⚪	burn_public	309,109	309,109		3,380	3,380		46,954	46,885	-69 (-0.1%)
⚪	mint_to_private	432,741	432,741		13,517	13,517		33,127	33,058	-69 (-0.2%)
⚪	mint_to_public	309,109	309,109		3,380	3,380		52,897	52,828	-69 (-0.1%)
⚪	transfer_private_to_private	428,037	428,037		24,218	24,218		6,706	6,706
⚪	transfer_private_to_public	439,053	439,053		14,081	14,081		46,417	46,404	-13 (-0.0%)
⚪	transfer_private_to_public_with_commitment	462,256	462,256		25,345	25,345		48,078	48,065	-13 (-0.0%)
⚪	transfer_public_to_private	429,376	429,376		13,517	13,517		44,812	44,799	-13 (-0.0%)
⚪	transfer_public_to_public	309,109	309,109		3,380	3,380		58,276	58,263	-13 (-0.0%)

Contract: tokenized_vault

	Function	Gates			DA Gas			L2 Gas
Status		Base	PR	Diff	Base	PR	Diff	Base	PR	Diff
⚪	deposit_private_to_private	672,409	672,409		15,770	15,770		130,412	130,191	-221 (-0.2%)
⚪	deposit_private_to_private_exact	695,042	695,042		27,034	27,034		105,536	105,384	-152 (-0.1%)
⚪	deposit_private_to_public	652,835	652,835		5,632	5,632		114,946	114,794	-152 (-0.1%)
⚪	deposit_public_to_private	433,425	433,425		16,896	16,896		222,122	221,776	-346 (-0.2%)
⚪	deposit_public_to_private_exact	456,094	456,094		28,161	28,161		197,246	196,969	-277 (-0.1%)
⚪	deposit_public_to_public	309,109	309,109		6,759	6,759		197,035	196,758	-277 (-0.1%)
⚪	issue_private_to_private_exact	795,419	795,419		27,034	27,034		133,066	132,845	-221 (-0.2%)
⚪	issue_private_to_public_exact	775,998	775,998		16,896	16,896		146,022	145,801	-221 (-0.2%)
⚪	issue_public_to_private	433,427	433,427		16,896	16,896		223,228	222,881	-347 (-0.2%)
⚪	issue_public_to_public	309,109	309,109		6,759	6,759		197,959	197,682	-277 (-0.1%)
⚪	redeem_private_to_public	439,114	439,114		5,069	5,069		131,465	131,244	-221 (-0.2%)
⚪	redeem_public_to_public	309,109	309,109		5,632	5,632		117,078	116,926	-152 (-0.1%)
⚪	withdraw_private_to_public_exact	461,834	461,834		16,333	16,333		117,339	117,187	-152 (-0.1%)
⚪	withdraw_public_to_public	309,109	309,109		5,632	5,632		117,002	116,850	-152 (-0.1%)

[cursor]

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on October 16.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

[github-actions]

Benchmark Comparison

Contract: nft

	Function	Gates			DA Gas			L2 Gas
Status		Base	PR	Diff	Base	PR	Diff	Base	PR	Diff
⚪	burn_private	414,611	414,611		2,816	2,816		43,789	43,789
⚪	burn_public	309,109	309,109		3,380	3,380		50,475	50,475
⚪	mint_to_private	431,929	431,929		13,517	13,517		43,565	43,565
⚪	mint_to_public	309,109	309,109		3,380	3,380		56,220	56,220
⚪	transfer_private_to_private	398,132	398,132		12,954	12,954		5,296	5,296
⚪	transfer_private_to_public	414,614	414,614		2,816	2,816		37,605	37,605
⚪	transfer_public_to_private	428,564	428,564		13,517	13,517		43,964	43,964
⚪	transfer_public_to_public	309,109	309,109		2,253	2,253		43,145	43,145

Contract: token

	Function	Gates			DA Gas			L2 Gas
Status		Base	PR	Diff	Base	PR	Diff	Base	PR	Diff
⚪	burn_private	438,977	438,977		14,081	14,081		34,956	34,887	-69 (-0.2%)
⚪	burn_public	309,109	309,109		3,380	3,380		46,954	46,885	-69 (-0.1%)
⚪	initialize_transfer_commitment	393,093	393,093		12,391	12,391		3,886	3,886
⚪	mint_to_private	432,741	432,741		13,517	13,517		33,127	33,058	-69 (-0.2%)
⚪	mint_to_public	309,109	309,109		3,380	3,380		52,897	52,828	-69 (-0.1%)
🔴	transfer_private_to_commitment	439,054	411,637	-27,417 (-6.2%)	14,644	15,207	+563 (+3.8%)	51,668	6,706	-44,962 (-87.0%)
⚪	transfer_private_to_private	428,037	428,037		24,218	24,218		6,706	6,706
⚪	transfer_private_to_public	439,053	439,053		14,081	14,081		46,417	46,404	-13 (-0.0%)
⚪	transfer_private_to_public_with_commitment	462,256	462,256		25,345	25,345		48,078	48,065	-13 (-0.0%)
⚪	transfer_public_to_commitment	309,109	309,109		3,943	3,943		62,774	62,761	-13 (-0.0%)
⚪	transfer_public_to_private	429,376	429,376		13,517	13,517		44,812	44,799	-13 (-0.0%)
⚪	transfer_public_to_public	309,109	309,109		3,380	3,380		58,276	58,263	-13 (-0.0%)

Contract: tokenized_vault

	Function	Gates			DA Gas			L2 Gas
Status		Base	PR	Diff	Base	PR	Diff	Base	PR	Diff
⚪	deposit_private_to_private	672,409	672,409		15,770	15,770		130,412	130,191	-221 (-0.2%)
⚪	deposit_private_to_private_exact	695,042	695,042		27,034	27,034		105,536	105,384	-152 (-0.1%)
⚪	deposit_private_to_public	652,835	652,835		5,632	5,632		114,946	114,794	-152 (-0.1%)
⚪	deposit_public_to_private	433,425	433,425		16,896	16,896		222,122	221,776	-346 (-0.2%)
⚪	deposit_public_to_private_exact	456,094	456,094		28,161	28,161		197,246	196,969	-277 (-0.1%)
⚪	deposit_public_to_public	309,109	309,109		6,759	6,759		197,035	196,758	-277 (-0.1%)
⚪	issue_private_to_private_exact	795,419	795,419		27,034	27,034		133,066	132,845	-221 (-0.2%)
⚪	issue_private_to_public_exact	775,998	775,998		16,896	16,896		146,022	145,801	-221 (-0.2%)
⚪	issue_public_to_private	433,427	433,427		16,896	16,896		223,228	222,881	-347 (-0.2%)
⚪	issue_public_to_public	309,109	309,109		6,759	6,759		197,959	197,682	-277 (-0.1%)
⚪	redeem_private_to_public	439,114	439,114		5,069	5,069		131,465	131,244	-221 (-0.2%)
⚪	redeem_public_to_public	309,109	309,109		5,632	5,632		117,078	116,926	-152 (-0.1%)
⚪	withdraw_private_to_public_exact	461,834	461,834		16,333	16,333		117,339	117,187	-152 (-0.1%)
⚪	withdraw_public_to_public	309,109	309,109		5,632	5,632		117,002	116,850	-152 (-0.1%)